Title: [117257] trunk/Source
- Revision
- 117257
- Author
- [email protected]
- Date
- 2012-05-16 04:20:21 -0700 (Wed, 16 May 2012)
Log Message
[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
https://bugs.webkit.org/show_bug.cgi?id=86589
Reviewed by Kent Tamura.
Source/Platform:
* chromium/public/WebTransformationMatrix.h: Added destructor.
(WebTransformationMatrix):
Source/WebCore:
Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.
No new tests. WebTransformationMatrixTest should pass on debug build.
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):
Modified Paths
Diff
Modified: trunk/Source/Platform/ChangeLog (117256 => 117257)
--- trunk/Source/Platform/ChangeLog 2012-05-16 11:13:06 UTC (rev 117256)
+++ trunk/Source/Platform/ChangeLog 2012-05-16 11:20:21 UTC (rev 117257)
@@ -1,3 +1,13 @@
+2012-05-16 Kenichi Ishibashi <[email protected]>
+
+ [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
+ https://bugs.webkit.org/show_bug.cgi?id=86589
+
+ Reviewed by Kent Tamura.
+
+ * chromium/public/WebTransformationMatrix.h: Added destructor.
+ (WebTransformationMatrix):
+
2012-05-15 Sheriff Bot <[email protected]>
Unreviewed, rolling out r117204.
Modified: trunk/Source/Platform/chromium/public/WebTransformationMatrix.h (117256 => 117257)
--- trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-05-16 11:13:06 UTC (rev 117256)
+++ trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-05-16 11:20:21 UTC (rev 117257)
@@ -51,6 +51,7 @@
WebTransformationMatrix();
WebTransformationMatrix(double a, double b, double c, double d, double e, double f);
WebTransformationMatrix(const WebTransformationMatrix&);
+ ~WebTransformationMatrix();
// Operations that return a separate matrix and do not modify this one.
WebTransformationMatrix inverse() const;
Modified: trunk/Source/WebCore/ChangeLog (117256 => 117257)
--- trunk/Source/WebCore/ChangeLog 2012-05-16 11:13:06 UTC (rev 117256)
+++ trunk/Source/WebCore/ChangeLog 2012-05-16 11:20:21 UTC (rev 117257)
@@ -1,3 +1,18 @@
+2012-05-16 Kenichi Ishibashi <[email protected]>
+
+ [Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
+ https://bugs.webkit.org/show_bug.cgi?id=86589
+
+ Reviewed by Kent Tamura.
+
+ Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.
+
+ No new tests. WebTransformationMatrixTest should pass on debug build.
+
+ * platform/chromium/support/WebTransformationMatrix.cpp:
+ (WebKit::WebTransformationMatrix::~WebTransformationMatrix):
+ (WebKit):
+
2012-05-16 Shinya Kawanaka <[email protected]>
ShadowRoot.selection should return the seleciton whose range is in a shadow tree.
Modified: trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp (117256 => 117257)
--- trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp 2012-05-16 11:13:06 UTC (rev 117256)
+++ trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp 2012-05-16 11:20:21 UTC (rev 117257)
@@ -50,6 +50,12 @@
{
}
+WebTransformationMatrix::~WebTransformationMatrix()
+{
+ // We need to call m_private.reset(0). See the comment of WebPrivateOwnPtr class.
+ m_private.reset(0);
+}
+
#if WEBKIT_IMPLEMENTATION
WebTransformationMatrix::WebTransformationMatrix(const TransformationMatrix& t)
: m_private(new TransformationMatrix(t))
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
