Title: [117534] trunk/Source/WebCore
- Revision
- 117534
- Author
- [email protected]
- Date
- 2012-05-17 20:24:44 -0700 (Thu, 17 May 2012)
Log Message
[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
https://bugs.webkit.org/show_bug.cgi?id=86708
Reviewed by Eric Seidel.
Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.
No new tests, no change in behavior.
* dom/ComposedShadowTreeWalker.h:
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117533 => 117534)
--- trunk/Source/WebCore/ChangeLog 2012-05-18 03:16:23 UTC (rev 117533)
+++ trunk/Source/WebCore/ChangeLog 2012-05-18 03:24:44 UTC (rev 117534)
@@ -1,3 +1,19 @@
+2012-05-17 Hayato Ito <[email protected]>
+
+ [Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
+ https://bugs.webkit.org/show_bug.cgi?id=86708
+
+ Reviewed by Eric Seidel.
+
+ Since InsertionPoint now has isActive() member function,
+ we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
+ using that function.
+
+ No new tests, no change in behavior.
+
+ * dom/ComposedShadowTreeWalker.h:
+ (WebCore::ComposedShadowTreeWalker::assertPrecondition):
+
2012-05-17 Ami Fischman <[email protected]>
[Chromium] Store HTTP version in WebURLResponse
Modified: trunk/Source/WebCore/dom/ComposedShadowTreeWalker.h (117533 => 117534)
--- trunk/Source/WebCore/dom/ComposedShadowTreeWalker.h 2012-05-18 03:16:23 UTC (rev 117533)
+++ trunk/Source/WebCore/dom/ComposedShadowTreeWalker.h 2012-05-18 03:24:44 UTC (rev 117534)
@@ -27,6 +27,7 @@
#ifndef ComposedShadowTreeWalker_h
#define ComposedShadowTreeWalker_h
+#include "InsertionPoint.h"
#include "ShadowRoot.h"
namespace WebCore {
@@ -80,9 +81,7 @@
ASSERT(!m_node->isShadowRoot());
else
ASSERT(!m_node->isShadowRoot() || toShadowRoot(m_node)->isYoungest());
- // FIXME: Add an assertion once InsertionPoint have isActive() function.
- // https://bugs.webkit.org/show_bug.cgi?id=82010
- // ASSERT(!isInsertionPoint(m_node) || !toInsertionPoint(node)->isActive());
+ ASSERT(!isInsertionPoint(m_node) || !toInsertionPoint(m_node)->isActive());
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
