Title: [117541] trunk/Source/WebCore
- Revision
- 117541
- Author
- [email protected]
- Date
- 2012-05-17 21:57:07 -0700 (Thu, 17 May 2012)
Log Message
AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
https://bugs.webkit.org/show_bug.cgi?id=75119
Patch by Wei James <[email protected]> on 2012-05-17
Reviewed by Chris Rogers.
As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117540 => 117541)
--- trunk/Source/WebCore/ChangeLog 2012-05-18 04:46:34 UTC (rev 117540)
+++ trunk/Source/WebCore/ChangeLog 2012-05-18 04:57:07 UTC (rev 117541)
@@ -1,3 +1,16 @@
+2012-05-17 Wei James <[email protected]>
+
+ AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
+ https://bugs.webkit.org/show_bug.cgi?id=75119
+
+ Reviewed by Chris Rogers.
+
+ As multiple channel support in AudioBus and other places is already
+ implemented, the check can be removed here.
+
+ * Modules/webaudio/MediaElementAudioSourceNode.cpp:
+ (WebCore::MediaElementAudioSourceNode::setFormat):
+
2012-05-17 Dan Bernstein <[email protected]>
<rdar://problem/11419933> Problems with flipped writing modes and compositing
Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp (117540 => 117541)
--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp 2012-05-18 04:46:34 UTC (rev 117540)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp 2012-05-18 04:57:07 UTC (rev 117541)
@@ -68,9 +68,7 @@
void MediaElementAudioSourceNode::setFormat(size_t numberOfChannels, float sourceSampleRate)
{
if (numberOfChannels != m_sourceNumberOfChannels || sourceSampleRate != m_sourceSampleRate) {
- // FIXME: implement multi-channel greater than stereo.
- // https://bugs.webkit.org/show_bug.cgi?id=75119
- if (!numberOfChannels || numberOfChannels > 2 || sourceSampleRate < minSampleRate || sourceSampleRate > maxSampleRate) {
+ if (!numberOfChannels || numberOfChannels > AudioContext::maxNumberOfChannels() || sourceSampleRate < minSampleRate || sourceSampleRate > maxSampleRate) {
// process() will generate silence for these uninitialized values.
LOG(Media, "MediaElementAudioSourceNode::setFormat(%u, %f) - unhandled format change", static_cast<unsigned>(numberOfChannels), sourceSampleRate);
m_sourceNumberOfChannels = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
