Title: [117546] trunk/Source/WebCore
- Revision
- 117546
- Author
- [email protected]
- Date
- 2012-05-17 22:50:42 -0700 (Thu, 17 May 2012)
Log Message
[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
https://bugs.webkit.org/show_bug.cgi?id=86803
Reviewed by Dimitri Glazkov.
V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().
No tests. No change in behavior.
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117545 => 117546)
--- trunk/Source/WebCore/ChangeLog 2012-05-18 05:44:42 UTC (rev 117545)
+++ trunk/Source/WebCore/ChangeLog 2012-05-18 05:50:42 UTC (rev 117546)
@@ -1,3 +1,22 @@
+2012-05-17 Kentaro Hara <[email protected]>
+
+ [V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
+ https://bugs.webkit.org/show_bug.cgi?id=86803
+
+ Reviewed by Dimitri Glazkov.
+
+ V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
+ only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
+ other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
+ Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
+ too, and remove V8Proxy::deletionNotHandledByInterceptor().
+
+ No tests. No change in behavior.
+
+ * bindings/v8/V8Proxy.h:
+ * bindings/v8/custom/V8StorageCustom.cpp:
+ (WebCore::storageDeleter):
+
2012-05-17 Ilya Tikhonovsky <[email protected]>
Web Inspector: speed-up markQueriableHeapObjects function.
Modified: trunk/Source/WebCore/bindings/v8/V8Proxy.h (117545 => 117546)
--- trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-05-18 05:44:42 UTC (rev 117545)
+++ trunk/Source/WebCore/bindings/v8/V8Proxy.h 2012-05-18 05:50:42 UTC (rev 117546)
@@ -320,11 +320,6 @@
return v8::Local<v8::Object>();
}
- inline static v8::Local<v8::Boolean> deletionNotHandledByInterceptor()
- {
- return v8::Local<v8::Boolean>();
- }
-
inline v8::Handle<v8::Primitive> throwError(const char* message, V8Proxy::ErrorType type, v8::Isolate* isolate = 0)
{
if (!v8::V8::IsExecutionTerminating())
Modified: trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp (117545 => 117546)
--- trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2012-05-18 05:44:42 UTC (rev 117545)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp 2012-05-18 05:50:42 UTC (rev 117546)
@@ -136,7 +136,7 @@
return v8::True();
}
- return deletionNotHandledByInterceptor();
+ return v8::Handle<v8::Boolean>();
}
v8::Handle<v8::Boolean> V8Storage::indexedPropertyDeleter(uint32_t index, const v8::AccessorInfo& info)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
