Title: [117552] trunk
- Revision
- 117552
- Author
- [email protected]
- Date
- 2012-05-18 00:06:58 -0700 (Fri, 18 May 2012)
Log Message
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Patch by Christophe Dumez <[email protected]> on 2012-05-18
Reviewed by Ryosuke Niwa.
Source/WebKit/efl:
No longer set the application cache path in ewk_main since the
path can only be set once and this prevents DRT (or apps) to set
it. Update the ewk_settings documentation to reflect these
changes.
* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.h:
Tools:
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (117551 => 117552)
--- trunk/Source/WebKit/efl/ChangeLog 2012-05-18 07:03:28 UTC (rev 117551)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-05-18 07:06:58 UTC (rev 117552)
@@ -1,5 +1,21 @@
2012-05-18 Christophe Dumez <[email protected]>
+ [EFL] appcache tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=86619
+
+ Reviewed by Ryosuke Niwa.
+
+ No longer set the application cache path in ewk_main since the
+ path can only be set once and this prevents DRT (or apps) to set
+ it. Update the ewk_settings documentation to reflect these
+ changes.
+
+ * ewk/ewk_main.cpp:
+ (_ewk_init_body):
+ * ewk/ewk_settings.h:
+
+2012-05-18 Christophe Dumez <[email protected]>
+
[EFL] Add simple implementation of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86354
Modified: trunk/Source/WebKit/efl/ewk/ewk_main.cpp (117551 => 117552)
--- trunk/Source/WebKit/efl/ewk/ewk_main.cpp 2012-05-18 07:03:28 UTC (rev 117551)
+++ trunk/Source/WebKit/efl/ewk/ewk_main.cpp 2012-05-18 07:06:58 UTC (rev 117552)
@@ -165,10 +165,8 @@
}
WTF::String webkitDirectory = home + "/.webkit";
- if (WebCore::makeAllDirectories(webkitDirectory)) {
+ if (WebCore::makeAllDirectories(webkitDirectory))
ewk_settings_web_database_path_set(webkitDirectory.utf8().data());
- ewk_settings_application_cache_path_set(webkitDirectory.utf8().data());
- }
ewk_network_tls_certificate_check_set(false);
Modified: trunk/Source/WebKit/efl/ewk/ewk_settings.h (117551 => 117552)
--- trunk/Source/WebKit/efl/ewk/ewk_settings.h 2012-05-18 07:03:28 UTC (rev 117551)
+++ trunk/Source/WebKit/efl/ewk/ewk_settings.h 2012-05-18 07:06:58 UTC (rev 117552)
@@ -196,7 +196,8 @@
* The Offline Application Caching APIs are part of HTML5 and allow applications to store data locally that is accessed
* when the network cannot be reached.
*
- * By default, the path is @c ~/.webkit.
+ * By default, the path is @c NULL, indicating that the feature is disabled. Once the path is set, the feature is enabled
+ * and the path cannot be changed.
*
* @param path where to store cache, must be write-able.
*
@@ -210,7 +211,7 @@
* The Offline Application Caching APIs are part of HTML5 and allow applications to store data locally that is accessed
* when the network cannot be reached.
*
- * By default, the path is @c ~/.webkit.
+ * By default, the path is @c NULL, indicating that the feature is disabled.
*
* @return eina_stringshare'd path value.
*
Modified: trunk/Tools/ChangeLog (117551 => 117552)
--- trunk/Tools/ChangeLog 2012-05-18 07:03:28 UTC (rev 117551)
+++ trunk/Tools/ChangeLog 2012-05-18 07:06:58 UTC (rev 117552)
@@ -1,3 +1,16 @@
+2012-05-18 Christophe Dumez <[email protected]>
+
+ [EFL] appcache tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=86619
+
+ Reviewed by Ryosuke Niwa.
+
+ Correctly set the application cache database path in EFL's
+ DumpRenderTree initialization code.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::initialize):
+
2012-05-17 Raphael Kubo da Costa <[email protected]>
[EFL][DRT] Call resetInternalsObject() after each test.
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (117551 => 117552)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-18 07:03:28 UTC (rev 117551)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-18 07:06:58 UTC (rev 117552)
@@ -162,6 +162,8 @@
ewk_settings_local_storage_path_set(path);
eina_str_join(path, sizeof(path), '/', drtTemp, "Databases");
ewk_settings_web_database_path_set(path);
+ eina_str_join(path, sizeof(path), '/', drtTemp, "Applications");
+ ewk_settings_application_cache_path_set(path);
}
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
