Title: [117565] trunk
- Revision
- 117565
- Author
- [email protected]
- Date
- 2012-05-18 02:00:28 -0700 (Fri, 18 May 2012)
Log Message
Unreviewed, rolling out r117556.
http://trac.webkit.org/changeset/117556
https://bugs.webkit.org/show_bug.cgi?id=86825
Wrong fix. IE still adds 1px padding. We're missing that in
textarea (Requested by rniwa on #webkit).
Patch by Sheriff Bot <[email protected]> on 2012-05-18
Source/WebCore:
* css/html.css:
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
LayoutTests:
* fast/forms/input-textarea-padding-match-expected.html: Removed.
* fast/forms/input-textarea-padding-match.html: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117564 => 117565)
--- trunk/LayoutTests/ChangeLog 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/LayoutTests/ChangeLog 2012-05-18 09:00:28 UTC (rev 117565)
@@ -1,3 +1,15 @@
+2012-05-18 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r117556.
+ http://trac.webkit.org/changeset/117556
+ https://bugs.webkit.org/show_bug.cgi?id=86825
+
+ Wrong fix. IE still adds 1px padding. We're missing that in
+ textarea (Requested by rniwa on #webkit).
+
+ * fast/forms/input-textarea-padding-match-expected.html: Removed.
+ * fast/forms/input-textarea-padding-match.html: Removed.
+
2012-05-18 Sudarsana Nagineni <[email protected]>
[EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
Deleted: trunk/LayoutTests/fast/forms/input-textarea-padding-match-expected.html (117564 => 117565)
--- trunk/LayoutTests/fast/forms/input-textarea-padding-match-expected.html 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/LayoutTests/fast/forms/input-textarea-padding-match-expected.html 2012-05-18 09:00:28 UTC (rev 117565)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This test ensures padding inside input and textarea elements match.</p>
-<style type="text/css">
-textarea {
- display: block;
- font-family: arial,sans-serif;
- border: none;
- padding: 0 0 0 10px;
- margin: 0;
- resize: none;
- width: 20px;
- height: 10px;
- overflow: hidden;
-}
-</style>
-<textarea>|</textarea>
-</body>
-</html>
Deleted: trunk/LayoutTests/fast/forms/input-textarea-padding-match.html (117564 => 117565)
--- trunk/LayoutTests/fast/forms/input-textarea-padding-match.html 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/LayoutTests/fast/forms/input-textarea-padding-match.html 2012-05-18 09:00:28 UTC (rev 117565)
@@ -1,20 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<p>This test ensures padding inside input and textarea elements match.</p>
-<style type="text/css">
-input {
- display: block;
- font-family: arial,sans-serif;
- border: none;
- padding: 0 0 0 10px;
- margin: 0;
- resize: none;
- width: 20px;
- height: 10px;
- overflow: hidden;
-}
-</style>
-<input type="text" value="|">
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (117564 => 117565)
--- trunk/Source/WebCore/ChangeLog 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/Source/WebCore/ChangeLog 2012-05-18 09:00:28 UTC (rev 117565)
@@ -1,3 +1,17 @@
+2012-05-18 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r117556.
+ http://trac.webkit.org/changeset/117556
+ https://bugs.webkit.org/show_bug.cgi?id=86825
+
+ Wrong fix. IE still adds 1px padding. We're missing that in
+ textarea (Requested by rniwa on #webkit).
+
+ * css/html.css:
+ (input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
+
2012-05-17 Pavel Feldman <[email protected]>
Web Inspector: remove File abstraction from the AdvancedSearchController, migrate it to UISourceCode.
Modified: trunk/Source/WebCore/css/html.css (117564 => 117565)
--- trunk/Source/WebCore/css/html.css 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/Source/WebCore/css/html.css 2012-05-18 09:00:28 UTC (rev 117565)
@@ -510,6 +510,8 @@
white-space: pre;
word-wrap: normal;
overflow: hidden;
+ padding-left: 1px;
+ padding-right: 1px;
}
input[type="password"] {
Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (117564 => 117565)
--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2012-05-18 08:53:05 UTC (rev 117564)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2012-05-18 09:00:28 UTC (rev 117565)
@@ -478,6 +478,10 @@
textBlockStyle->setDisplay(BLOCK);
+ // We're adding one extra pixel of padding to match WinIE.
+ textBlockStyle->setPaddingLeft(Length(1, Fixed));
+ textBlockStyle->setPaddingRight(Length(1, Fixed));
+
return textBlockStyle.release();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
