Diff
Modified: trunk/LayoutTests/ChangeLog (117591 => 117592)
--- trunk/LayoutTests/ChangeLog 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/LayoutTests/ChangeLog 2012-05-18 14:38:14 UTC (rev 117592)
@@ -1,3 +1,14 @@
+2012-05-18 Hugo Parente Lima <[email protected]>
+
+ [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=86731
+
+ Reviewed by Simon Hausmann.
+
+ Unskip fast/events/page-visibility-iframe-move-test.html.
+
+ * platform/qt-5.0-wk2/Skipped:
+
2012-05-18 Raphael Kubo da Costa <[email protected]>
[EFL] Unreviewed gardening.
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (117591 => 117592)
--- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-05-18 14:38:14 UTC (rev 117592)
@@ -73,10 +73,6 @@
fast/forms/select-accesskey.html
fast/loader/policy-delegate-action-hit-test-zoomed.html
-# Still failing after implementing layoutTestController.setPageVisibility()
-# https://bugs.webkit.org/show_bug.cgi?id=83263
-fast/events/page-visibility-iframe-move-test.html
-
svg/custom/use-events-crash.svg
# eventSender.mouseScrollBy() is unimplemented
Modified: trunk/Source/WebKit2/ChangeLog (117591 => 117592)
--- trunk/Source/WebKit2/ChangeLog 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-18 14:38:14 UTC (rev 117592)
@@ -1,3 +1,21 @@
+2012-05-18 Hugo Parente Lima <[email protected]>
+
+ [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=86731
+
+ Reviewed by Simon Hausmann.
+
+ Set the page visibility on a single page instead of on all pages
+ from the page group.
+
+ * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
+ (WKBundleSetPageVisibilityState):
+ * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
+ * WebProcess/InjectedBundle/InjectedBundle.cpp:
+ (WebKit::InjectedBundle::setPageVisibilityState):
+ * WebProcess/InjectedBundle/InjectedBundle.h:
+ (InjectedBundle):
+
2012-05-18 MORITA Hajime <[email protected]>
Yet another unreviewed build fix on r117572, this time for wk2...
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp (117591 => 117592)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp 2012-05-18 14:38:14 UTC (rev 117592)
@@ -241,7 +241,7 @@
return InjectedBundle::isProcessingUserGesture();
}
-void WKBundleSetPageVisibilityState(WKBundleRef bundleRef, WKBundlePageGroupRef pageGroupRef, int state, bool isInitialState)
+void WKBundleSetPageVisibilityState(WKBundleRef bundleRef, WKBundlePageRef pageRef, int state, bool isInitialState)
{
- toImpl(bundleRef)->setPageVisibilityState(toImpl(pageGroupRef), state, isInitialState);
+ toImpl(bundleRef)->setPageVisibilityState(toImpl(pageRef), state, isInitialState);
}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h (117591 => 117592)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h 2012-05-18 14:38:14 UTC (rev 117592)
@@ -90,7 +90,7 @@
WK_EXPORT void WKBundleSwitchNetworkLoaderToNewTestingSession(WKBundleRef bundle);
-WK_EXPORT void WKBundleSetPageVisibilityState(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, int state, bool isInitialState);
+WK_EXPORT void WKBundleSetPageVisibilityState(WKBundleRef bundle, WKBundlePageRef page, int state, bool isInitialState);
#ifdef __cplusplus
}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp (117591 => 117592)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp 2012-05-18 14:38:14 UTC (rev 117592)
@@ -458,12 +458,10 @@
ASSERT_NOT_REACHED();
}
-void InjectedBundle::setPageVisibilityState(WebPageGroupProxy* pageGroup, int state, bool isInitialState)
+void InjectedBundle::setPageVisibilityState(WebPage* page, int state, bool isInitialState)
{
#if ENABLE(PAGE_VISIBILITY_API)
- const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
- for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
- (*iter)->setVisibilityState(static_cast<PageVisibilityState>(state), isInitialState);
+ page->corePage()->setVisibilityState(static_cast<PageVisibilityState>(state), isInitialState);
#endif
}
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h (117591 => 117592)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h 2012-05-18 14:38:14 UTC (rev 117592)
@@ -156,7 +156,7 @@
static bool isProcessingUserGesture();
- void setPageVisibilityState(WebPageGroupProxy*, int state, bool isInitialState);
+ void setPageVisibilityState(WebPage*, int state, bool isInitialState);
private:
InjectedBundle(const String&);
Modified: trunk/Tools/ChangeLog (117591 => 117592)
--- trunk/Tools/ChangeLog 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Tools/ChangeLog 2012-05-18 14:38:14 UTC (rev 117592)
@@ -1,3 +1,17 @@
+2012-05-18 Hugo Parente Lima <[email protected]>
+
+ [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=86731
+
+ Reviewed by Simon Hausmann.
+
+ Set the page visibility on a single page instead of on all pages
+ from the page group.
+
+ * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
+ (WTR::LayoutTestController::setPageVisibility):
+ (WTR::LayoutTestController::resetPageVisibility):
+
2012-05-18 Yi Shen <[email protected]>
REGRESSION (r102553): Smart links do not work
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp (117591 => 117592)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-05-18 14:28:33 UTC (rev 117591)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp 2012-05-18 14:38:14 UTC (rev 117592)
@@ -554,12 +554,12 @@
else if (JSStringIsEqualToUTF8CString(state, "preview"))
visibilityState = WebCore::PageVisibilityStatePreview;
- WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), visibilityState, /* isInitialState */ false);
+ WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().page()->page(), visibilityState, /* isInitialState */ false);
}
void LayoutTestController::resetPageVisibility()
{
- WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().pageGroup(), WebCore::PageVisibilityStateVisible, /* isInitialState */ true);
+ WKBundleSetPageVisibilityState(InjectedBundle::shared().bundle(), InjectedBundle::shared().page()->page(), WebCore::PageVisibilityStateVisible, /* isInitialState */ true);
}
void LayoutTestController::dumpConfigurationForViewport(int deviceDPI, int deviceWidth, int deviceHeight, int availableWidth, int availableHeight)
