Title: [117599] trunk
- Revision
- 117599
- Author
- [email protected]
- Date
- 2012-05-18 08:57:26 -0700 (Fri, 18 May 2012)
Log Message
Web Inspector: error when expanding an HTMLAllCollection object in the console
https://bugs.webkit.org/show_bug.cgi?id=86741
Reviewed by Pavel Feldman.
Source/WebCore:
RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.
* inspector/InjectedScriptSource.js:
LayoutTests:
* inspector/console/inspect-html-all-collection.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117598 => 117599)
--- trunk/LayoutTests/ChangeLog 2012-05-18 15:39:46 UTC (rev 117598)
+++ trunk/LayoutTests/ChangeLog 2012-05-18 15:57:26 UTC (rev 117599)
@@ -1,3 +1,12 @@
+2012-05-18 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: error when expanding an HTMLAllCollection object in the console
+ https://bugs.webkit.org/show_bug.cgi?id=86741
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/console/inspect-html-all-collection.html:
+
2012-05-18 Krzysztof Czech <[email protected]>, Mariusz Grzegorczyk <[email protected]>
[EFL] Gardening failure test cases.
Modified: trunk/LayoutTests/inspector/console/inspect-html-all-collection.html (117598 => 117599)
--- trunk/LayoutTests/inspector/console/inspect-html-all-collection.html 2012-05-18 15:39:46 UTC (rev 117598)
+++ trunk/LayoutTests/inspector/console/inspect-html-all-collection.html 2012-05-18 15:57:26 UTC (rev 117599)
@@ -14,7 +14,7 @@
return;
}
var htmlAllCollection = WebInspector.RemoteObject.fromPayload(result);
- htmlAllCollection.callFunctionJSON("function() { return this.length; }", [], didGetLength.bind(this));
+ htmlAllCollection.callFunctionJSON("function(collection) { return this.length + collection.length; }", [{objectId: htmlAllCollection.objectId}], didGetLength.bind(this));
}
function didGetLength(len)
Modified: trunk/Source/WebCore/ChangeLog (117598 => 117599)
--- trunk/Source/WebCore/ChangeLog 2012-05-18 15:39:46 UTC (rev 117598)
+++ trunk/Source/WebCore/ChangeLog 2012-05-18 15:57:26 UTC (rev 117599)
@@ -1,3 +1,14 @@
+2012-05-18 Yury Semikhatsky <[email protected]>
+
+ Web Inspector: error when expanding an HTMLAllCollection object in the console
+ https://bugs.webkit.org/show_bug.cgi?id=86741
+
+ Reviewed by Pavel Feldman.
+
+ RuntimeAgent.callFunctionOn should work correcly with arguments of type HTMLAllCollection.
+
+ * inspector/InjectedScriptSource.js:
+
2012-05-18 Pavel Feldman <[email protected]>
Web Inspector: resource revision content is not rendered properly. Resource content is shown instead.
Modified: trunk/Source/WebCore/inspector/InjectedScriptSource.js (117598 => 117599)
--- trunk/Source/WebCore/inspector/InjectedScriptSource.js 2012-05-18 15:39:46 UTC (rev 117598)
+++ trunk/Source/WebCore/inspector/InjectedScriptSource.js 2012-05-18 15:57:26 UTC (rev 117599)
@@ -285,7 +285,7 @@
return "Arguments should belong to the same _javascript_ world as the target object.";
var resolvedArg = this._objectForId(parsedArgId);
- if (!resolvedArg)
+ if (!this._isDefined(resolvedArg))
return "Could not find object with given id";
resolvedArgs.push(resolvedArg);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
