Title: [117726] trunk
- Revision
- 117726
- Author
- [email protected]
- Date
- 2012-05-20 22:05:57 -0700 (Sun, 20 May 2012)
Log Message
[Chromium] Enable datalist for input type email
https://bugs.webkit.org/show_bug.cgi?id=85356
Reviewed by Kent Tamura.
Source/WebCore:
No new tests. Covered in fast/forms/datalist/input-list.html
* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI):
LayoutTests:
* platform/chromium/fast/forms/datalist/input-list-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117725 => 117726)
--- trunk/LayoutTests/ChangeLog 2012-05-21 05:03:33 UTC (rev 117725)
+++ trunk/LayoutTests/ChangeLog 2012-05-21 05:05:57 UTC (rev 117726)
@@ -1,3 +1,12 @@
+2012-05-20 Keishi Hattori <[email protected]>
+
+ [Chromium] Enable datalist for input type email
+ https://bugs.webkit.org/show_bug.cgi?id=85356
+
+ Reviewed by Kent Tamura.
+
+ * platform/chromium/fast/forms/datalist/input-list-expected.txt:
+
2012-05-20 Joe Thomas <[email protected]>
Unsupported commands should have queryCommandValue() = "", not false
Modified: trunk/LayoutTests/platform/chromium/fast/forms/datalist/input-list-expected.txt (117725 => 117726)
--- trunk/LayoutTests/platform/chromium/fast/forms/datalist/input-list-expected.txt 2012-05-21 05:03:33 UTC (rev 117725)
+++ trunk/LayoutTests/platform/chromium/fast/forms/datalist/input-list-expected.txt 2012-05-21 05:05:57 UTC (rev 117726)
@@ -11,7 +11,7 @@
PASS document.getElementById("search").list is document.getElementById("dl1")
PASS document.getElementById("url").list is document.getElementById("dl1")
PASS document.getElementById("telephone").list is document.getElementById("dl1")
-FAIL document.getElementById("email").list should be [object HTMLDataListElement]. Was null.
+PASS document.getElementById("email").list is document.getElementById("dl1")
PASS document.getElementById("datetime").list is document.getElementById("dl1")
FAIL document.getElementById("date").list should be [object HTMLDataListElement]. Was null.
PASS document.getElementById("month").list is document.getElementById("dl1")
Modified: trunk/Source/WebCore/ChangeLog (117725 => 117726)
--- trunk/Source/WebCore/ChangeLog 2012-05-21 05:03:33 UTC (rev 117725)
+++ trunk/Source/WebCore/ChangeLog 2012-05-21 05:05:57 UTC (rev 117726)
@@ -1,3 +1,15 @@
+2012-05-20 Keishi Hattori <[email protected]>
+
+ [Chromium] Enable datalist for input type email
+ https://bugs.webkit.org/show_bug.cgi?id=85356
+
+ Reviewed by Kent Tamura.
+
+ No new tests. Covered in fast/forms/datalist/input-list.html
+
+ * rendering/RenderThemeChromiumCommon.cpp:
+ (WebCore::RenderThemeChromiumCommon::supportsDataListUI):
+
2012-05-20 Kentaro Hara <[email protected]>
[V8] Pass Isolate to throwError()s in CodeGeneratorV8.pm
Modified: trunk/Source/WebCore/rendering/RenderThemeChromiumCommon.cpp (117725 => 117726)
--- trunk/Source/WebCore/rendering/RenderThemeChromiumCommon.cpp 2012-05-21 05:03:33 UTC (rev 117725)
+++ trunk/Source/WebCore/rendering/RenderThemeChromiumCommon.cpp 2012-05-21 05:05:57 UTC (rev 117726)
@@ -34,7 +34,7 @@
{
// FIXME: We still need to support email, datetime, date, month, week, time, datetime-local, range, color.
return type == InputTypeNames::text() || type == InputTypeNames::search() || type == InputTypeNames::url()
- || type == InputTypeNames::telephone() || type == InputTypeNames::number();
+ || type == InputTypeNames::telephone() || type == InputTypeNames::email() || type == InputTypeNames::number();
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
