Title: [117752] trunk
- Revision
- 117752
- Author
- [email protected]
- Date
- 2012-05-21 02:43:48 -0700 (Mon, 21 May 2012)
Log Message
[EFL] PlatformKeyboardEventEfl is missing ESC key handling.
https://bugs.webkit.org/show_bug.cgi?id=86837
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-05-21
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added ESC key handling.
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::createKeyMap):
(WebCore::singleCharacterString):
Tools:
* DumpRenderTree/efl/EventSender.cpp:
(keyNameFromJSValue): Added ESC key handling.
LayoutTests:
* platform/efl/Skipped: Unskipped fast/forms/input-search-press-escape-key.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (117751 => 117752)
--- trunk/LayoutTests/ChangeLog 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/LayoutTests/ChangeLog 2012-05-21 09:43:48 UTC (rev 117752)
@@ -1,3 +1,12 @@
+2012-05-21 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+ https://bugs.webkit.org/show_bug.cgi?id=86837
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * platform/efl/Skipped: Unskipped fast/forms/input-search-press-escape-key.html.
+
2012-05-18 Ilya Tikhonovsky <[email protected]>
Web Inspector: upstream build dominators tree procedure from v8.
Modified: trunk/LayoutTests/platform/efl/Skipped (117751 => 117752)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-21 09:43:48 UTC (rev 117752)
@@ -675,7 +675,6 @@
fast/events/key-events-in-input-button.html
fast/events/key-events-in-input-text.html
fast/events/option-tab.html
-fast/forms/input-search-press-escape-key.html
# BUG: not scrolling correctly
fast/events/mousedown-in-subframe-scrollbar.html
Modified: trunk/Source/WebCore/ChangeLog (117751 => 117752)
--- trunk/Source/WebCore/ChangeLog 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/Source/WebCore/ChangeLog 2012-05-21 09:43:48 UTC (rev 117752)
@@ -1,3 +1,16 @@
+2012-05-21 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+ https://bugs.webkit.org/show_bug.cgi?id=86837
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Added ESC key handling.
+
+ * platform/efl/EflKeyboardUtilities.cpp:
+ (WebCore::createKeyMap):
+ (WebCore::singleCharacterString):
+
2012-05-21 Pavel Feldman <[email protected]>
Web Inspector: move sources panel out of experimental.
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (117751 => 117752)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-05-21 09:43:48 UTC (rev 117752)
@@ -84,6 +84,7 @@
keyMap().set("ISO_Left_Tab", "U+0009");
keyMap().set("BackSpace", "U+0008");
keyMap().set("space", "U+0020");
+ keyMap().set("Escape", "U+001B");
keyMap().set("Print", "PrintScreen");
// Keypad location
keyMap().set("KP_Left", "Left");
@@ -223,6 +224,9 @@
return String("\t");
if (keyName == "Print")
return String("");
+ if (keyName == "Escape")
+ return String("\x1b");
+
return keyName;
}
Modified: trunk/Tools/ChangeLog (117751 => 117752)
--- trunk/Tools/ChangeLog 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/Tools/ChangeLog 2012-05-21 09:43:48 UTC (rev 117752)
@@ -1,3 +1,13 @@
+2012-05-21 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
+ https://bugs.webkit.org/show_bug.cgi?id=86837
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ * DumpRenderTree/efl/EventSender.cpp:
+ (keyNameFromJSValue): Added ESC key handling.
+
2012-05-20 Carlos Garcia Campos <[email protected]>
[GTK] Add GCancellable parameter to all methods using gio async pattern
Modified: trunk/Tools/DumpRenderTree/efl/EventSender.cpp (117751 => 117752)
--- trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-21 09:30:02 UTC (rev 117751)
+++ trunk/Tools/DumpRenderTree/efl/EventSender.cpp 2012-05-21 09:43:48 UTC (rev 117752)
@@ -448,6 +448,8 @@
return new KeyEventInfo("BackSpace", "BackSpace", modifiers);
if (charCode == ' ')
return new KeyEventInfo("space", " ", modifiers);
+ if (charCode == '\x1B')
+ return new KeyEventInfo("Escape", "Escape", modifiers);
return new KeyEventInfo(character->ustring().utf8(), character->ustring().utf8(), modifiers);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
