Title: [117917] trunk/Source/WebCore
- Revision
- 117917
- Author
- [email protected]
- Date
- 2012-05-21 23:52:44 -0700 (Mon, 21 May 2012)
Log Message
Web Inspector: "Deactivate All Breakpoints" should visually get reflected in Breakpoints pane.
https://bugs.webkit.org/show_bug.cgi?id=86844
Patch by Sam D <[email protected]> on 2012-05-21
Reviewed by Pavel Feldman.
Added an option for activate/deactivate breakpoints into Breakpoints
pane section. Style properties has been attached with
breakpoint list to reflect active state of breakpoints.
No new tests. UI Change.
* English.lproj/localizedStrings.js:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointContextMenu):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
* inspector/front-end/inspector.css:
(.breakpoints-list-deactivated):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117916 => 117917)
--- trunk/Source/WebCore/ChangeLog 2012-05-22 06:51:09 UTC (rev 117916)
+++ trunk/Source/WebCore/ChangeLog 2012-05-22 06:52:44 UTC (rev 117917)
@@ -1,3 +1,24 @@
+2012-05-21 Sam D <[email protected]>
+
+ Web Inspector: "Deactivate All Breakpoints" should visually get reflected in Breakpoints pane.
+ https://bugs.webkit.org/show_bug.cgi?id=86844
+
+ Reviewed by Pavel Feldman.
+
+ Added an option for activate/deactivate breakpoints into Breakpoints
+ pane section. Style properties has been attached with
+ breakpoint list to reflect active state of breakpoints.
+
+ No new tests. UI Change.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/BreakpointsSidebarPane.js:
+ (WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointContextMenu):
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
+ * inspector/front-end/inspector.css:
+ (.breakpoints-list-deactivated):
+
2012-05-21 Alexis Menard <[email protected]>
Web Inspector: Remove some dead code in CSSStyleModel.js.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js
(Binary files differ)
Modified: trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js (117916 => 117917)
--- trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-05-22 06:51:09 UTC (rev 117916)
+++ trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-05-22 06:52:44 UTC (rev 117917)
@@ -171,6 +171,10 @@
contextMenu.appendItem(WebInspector.UIString("Remove Breakpoint"), breakpoint.remove.bind(breakpoint));
var removeAllTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Remove all _javascript_ breakpoints" : "Remove All _javascript_ Breakpoints");
contextMenu.appendItem(removeAllTitle, this._breakpointManager.removeAllBreakpoints.bind(this._breakpointManager));
+
+ var breakpointActive = WebInspector.debuggerModel.breakpointsActive();
+ var breakpointActiveTitle = WebInspector.UIString(breakpointActive ? "Deactivate All Breakpoints" : "Activate All Breakpoints");
+ contextMenu.appendItem(breakpointActiveTitle, WebInspector.debuggerModel.setBreakpointsActive.bind(WebInspector.debuggerModel, !breakpointActive));
contextMenu.show(event);
},
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (117916 => 117917)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-05-22 06:51:09 UTC (rev 117916)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-05-22 06:52:44 UTC (rev 117917)
@@ -777,9 +777,11 @@
if (active) {
this._toggleBreakpointsButton.title = WebInspector.UIString("Deactivate all breakpoints.");
WebInspector.inspectorView.element.removeStyleClass("breakpoints-deactivated");
+ this.sidebarPanes.jsBreakpoints.listElement.removeStyleClass("breakpoints-list-deactivated");
} else {
this._toggleBreakpointsButton.title = WebInspector.UIString("Activate all breakpoints.");
WebInspector.inspectorView.element.addStyleClass("breakpoints-deactivated");
+ this.sidebarPanes.jsBreakpoints.listElement.addStyleClass("breakpoints-list-deactivated");
}
},
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (117916 => 117917)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-22 06:51:09 UTC (rev 117916)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2012-05-22 06:52:44 UTC (rev 117917)
@@ -2139,6 +2139,11 @@
margin: 0;
}
+.breakpoints-list-deactivated {
+ background-color: rgb(245, 245, 245);
+ opacity: 0.3;
+}
+
.breakpoint-list li {
white-space: nowrap;
text-overflow: ellipsis;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
