Title: [118096] trunk/Source/WebCore
- Revision
- 118096
- Author
- [email protected]
- Date
- 2012-05-22 18:53:08 -0700 (Tue, 22 May 2012)
Log Message
Fix a crash in HTMLFormControlElement::disabled().
https://bugs.webkit.org/show_bug.cgi?id=86534
Reviewed by Hajime Morita.
Node::removedFrom() was not called in some cases. This patch fixes it.
No new tests. It's almost impossible to make a reliable test.
* dom/ContainerNodeAlgorithms.h:
Remove inDocument() check so that Node::removedFrom() is called even if
a parent node in an orphan tree is deleted but a child node remains,
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118095 => 118096)
--- trunk/Source/WebCore/ChangeLog 2012-05-23 01:41:29 UTC (rev 118095)
+++ trunk/Source/WebCore/ChangeLog 2012-05-23 01:53:08 UTC (rev 118096)
@@ -1,3 +1,18 @@
+2012-05-22 Kent Tamura <[email protected]>
+
+ Fix a crash in HTMLFormControlElement::disabled().
+ https://bugs.webkit.org/show_bug.cgi?id=86534
+
+ Reviewed by Hajime Morita.
+
+ Node::removedFrom() was not called in some cases. This patch fixes it.
+
+ No new tests. It's almost impossible to make a reliable test.
+
+ * dom/ContainerNodeAlgorithms.h:
+ Remove inDocument() check so that Node::removedFrom() is called even if
+ a parent node in an orphan tree is deleted but a child node remains,
+
2012-05-22 James Robinson <[email protected]>
Add a Setting to make position:fixed form a new stacking context
Modified: trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h (118095 => 118096)
--- trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2012-05-23 01:41:29 UTC (rev 118095)
+++ trunk/Source/WebCore/dom/ContainerNodeAlgorithms.h 2012-05-23 01:53:08 UTC (rev 118096)
@@ -135,8 +135,7 @@
// Clean up any TreeScope to a removed tree.
if (Document* containerDocument = container->ownerDocument())
containerDocument->adoptIfNeeded(node);
- if (node->inDocument())
- ChildNodeRemovalNotifier(container).notify(node);
+ ChildNodeRemovalNotifier(container).notify(node);
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes