Title: [118098] trunk/Source/WebCore
- Revision
- 118098
- Author
- [email protected]
- Date
- 2012-05-22 19:03:09 -0700 (Tue, 22 May 2012)
Log Message
<shadow> and <content> should be hidden behind ContextEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=87063
This change repalces "runtimeConditional" tag definition property
with new "contextConditional" property, which refers
ContextEnabledFeatures instead of RuntimeEnabledFeatures.
Reviewed by Dimitri Glazkov.
No new tests. DRT cannot test this. No behaviour change on DRT.
* dom/make_names.pl:
(defaultTagPropertyHash):
(printConstructorInterior):
(printFactoryCppFile):
(printWrapperFunctions):
(printWrapperFactoryCppFile):
* html/HTMLTagNames.in:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118097 => 118098)
--- trunk/Source/WebCore/ChangeLog 2012-05-23 01:58:23 UTC (rev 118097)
+++ trunk/Source/WebCore/ChangeLog 2012-05-23 02:03:09 UTC (rev 118098)
@@ -1,3 +1,24 @@
+2012-05-22 MORITA Hajime <[email protected]>
+
+ <shadow> and <content> should be hidden behind ContextEnabledFeatures
+ https://bugs.webkit.org/show_bug.cgi?id=87063
+
+ This change repalces "runtimeConditional" tag definition property
+ with new "contextConditional" property, which refers
+ ContextEnabledFeatures instead of RuntimeEnabledFeatures.
+
+ Reviewed by Dimitri Glazkov.
+
+ No new tests. DRT cannot test this. No behaviour change on DRT.
+
+ * dom/make_names.pl:
+ (defaultTagPropertyHash):
+ (printConstructorInterior):
+ (printFactoryCppFile):
+ (printWrapperFunctions):
+ (printWrapperFactoryCppFile):
+ * html/HTMLTagNames.in:
+
2012-05-22 Kent Tamura <[email protected]>
Fix a crash in HTMLFormControlElement::disabled().
Modified: trunk/Source/WebCore/dom/make_names.pl (118097 => 118098)
--- trunk/Source/WebCore/dom/make_names.pl 2012-05-23 01:58:23 UTC (rev 118097)
+++ trunk/Source/WebCore/dom/make_names.pl 2012-05-23 02:03:09 UTC (rev 118098)
@@ -186,7 +186,7 @@
'mapToTagName' => '',
'wrapperOnlyIfMediaIsAvailable' => 0,
'conditional' => 0,
- 'runtimeConditional' => 0
+ 'contextConditional' => 0
);
}
@@ -375,10 +375,10 @@
;
}
- my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
- if ($runtimeConditional) {
+ my $contextConditional = $enabledTags{$tagName}{contextConditional};
+ if ($contextConditional) {
print F <<END
- if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled())
+ if (!ContextEnabledFeatures::${contextConditional}Enabled(document->domWindow()))
return 0;
END
;
@@ -804,7 +804,7 @@
print F <<END
-#include "RuntimeEnabledFeatures.h"
+#include "ContextEnabledFeatures.h"
#if ENABLE(DASHBOARD_SUPPORT) || ENABLE(VIDEO)
#include "Document.h"
@@ -1008,12 +1008,12 @@
END
;
- } elsif ($enabledTags{$tagName}{runtimeConditional}) {
- my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
+ } elsif ($enabledTags{$tagName}{contextConditional}) {
+ my $contextConditional = $enabledTags{$tagName}{contextConditional};
print F <<END
static JSDOMWrapper* create${JSInterfaceName}Wrapper(ExecState* exec, JSDOMGlobalObject* globalObject, PassRefPtr<$parameters{namespace}Element> element)
{
- if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled()) {
+ if (!ContextEnabledFeatures::${contextConditional}Enabled(element->document()->domWindow())) {
ASSERT(!element || element->is$parameters{fallbackInterfaceName}());
return CREATE_DOM_WRAPPER(exec, globalObject, $parameters{fallbackInterfaceName}, element.get());
}
@@ -1045,12 +1045,12 @@
END
;
- } elsif ($enabledTags{$tagName}{runtimeConditional}) {
- my $runtimeConditional = $enabledTags{$tagName}{runtimeConditional};
+ } elsif ($enabledTags{$tagName}{contextConditional}) {
+ my $contextConditional = $enabledTags{$tagName}{contextConditional};
print F <<END
static v8::Handle<v8::Value> create${JSInterfaceName}Wrapper($parameters{namespace}Element* element, v8::Isolate* isolate)
{
- if (!RuntimeEnabledFeatures::${runtimeConditional}Enabled())
+ if (!ContextEnabledFeatures::${contextConditional}Enabled(element->document()->domWindow()))
return V8$parameters{fallbackInterfaceName}::wrap(to$parameters{fallbackInterfaceName}(element), isolate);
return toV8(static_cast<${JSInterfaceName}*>(element), isolate);
}
@@ -1111,7 +1111,7 @@
print F <<END
-#include "RuntimeEnabledFeatures.h"
+#include "ContextEnabledFeatures.h"
#if ENABLE(VIDEO)
#include "Document.h"
Modified: trunk/Source/WebCore/html/HTMLTagNames.in (118097 => 118098)
--- trunk/Source/WebCore/html/HTMLTagNames.in 2012-05-23 01:58:23 UTC (rev 118097)
+++ trunk/Source/WebCore/html/HTMLTagNames.in 2012-05-23 02:03:09 UTC (rev 118098)
@@ -31,7 +31,7 @@
col interfaceName=HTMLTableColElement
colgroup interfaceName=HTMLTableColElement
command interfaceName=HTMLElement
-content interfaceName=HTMLContentElement, conditional=SHADOW_DOM, runtimeConditional=shadowDOM
+content interfaceName=HTMLContentElement, conditional=SHADOW_DOM, contextConditional=shadowDOM
webkitShadowContent interfaceName=HTMLElement, noConstructor
datalist interfaceName=HTMLDataListElement, conditional=DATALIST
dd interfaceName=HTMLElement
@@ -95,7 +95,7 @@
optgroup interfaceName=HTMLOptGroupElement
option
output constructorNeedsFormElement
-shadow interfaceName=HTMLShadowElement, conditional=SHADOW_DOM, runtimeConditional=shadowDOM
+shadow interfaceName=HTMLShadowElement, conditional=SHADOW_DOM, contextConditional=shadowDOM
p interfaceName=HTMLParagraphElement
param
plaintext interfaceName=HTMLElement
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
