Title: [118241] trunk
Revision
118241
Author
[email protected]
Date
2012-05-23 13:58:48 -0700 (Wed, 23 May 2012)

Log Message

[EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87092

Patch by Christophe Dumez <[email protected]> on 2012-05-23
Reviewed by Adam Barth.

Source/WebCore:

Remove readonly keyword from the webkitIntent attribute. This is
needed otherwise the [Replaceable] extended attribute has not effect
with JSC. This is tested by webintents/web-intents-delivery-reuse.html
test case.

* Modules/intents/DOMWindowIntents.idl:

LayoutTests:

Remove webintents/web-intents-delivery-reuse.html from test
expectations now that window.webkitIntent is really replaceable and
now that the test is passing.

* platform/efl/test_expectations.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118240 => 118241)


--- trunk/LayoutTests/ChangeLog	2012-05-23 20:52:42 UTC (rev 118240)
+++ trunk/LayoutTests/ChangeLog	2012-05-23 20:58:48 UTC (rev 118241)
@@ -1,3 +1,16 @@
+2012-05-23  Christophe Dumez  <[email protected]>
+
+        [EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
+        https://bugs.webkit.org/show_bug.cgi?id=87092
+
+        Reviewed by Adam Barth.
+
+        Remove webintents/web-intents-delivery-reuse.html from test
+        expectations now that window.webkitIntent is really replaceable and
+        now that the test is passing.
+
+        * platform/efl/test_expectations.txt:
+
 2012-05-23  Abhishek Arya  <[email protected]>
 
         ASSERT failure toRenderProgress in HTMLProgressElement::didElementStateChange

Modified: trunk/LayoutTests/platform/efl/test_expectations.txt (118240 => 118241)


--- trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-23 20:52:42 UTC (rev 118240)
+++ trunk/LayoutTests/platform/efl/test_expectations.txt	2012-05-23 20:58:48 UTC (rev 118241)
@@ -621,7 +621,6 @@
 // Incomplete Web Intents support
 BUGWK86866 SKIP : webintents/intent-tag.html = TEXT
 BUGWK86865 SKIP : webintents/web-intents-delivery.html = TEXT
-BUGWK87092 SKIP : webintents/web-intents-delivery-reuse.html = TEXT
 BUGWK86867 SKIP : webintents/web-intents-failure.html = TEXT
 BUGWK86841 SKIP : webintents/web-intents-invoke-port.html = TEXT
 BUGWK86873 SKIP : webintents/web-intents-obj-constructor.html = TEXT

Modified: trunk/Source/WebCore/ChangeLog (118240 => 118241)


--- trunk/Source/WebCore/ChangeLog	2012-05-23 20:52:42 UTC (rev 118240)
+++ trunk/Source/WebCore/ChangeLog	2012-05-23 20:58:48 UTC (rev 118241)
@@ -1,3 +1,17 @@
+2012-05-23  Christophe Dumez  <[email protected]>
+
+        [EFL] webintents/web-intents-delivery-reuse.html is failing on EFL port
+        https://bugs.webkit.org/show_bug.cgi?id=87092
+
+        Reviewed by Adam Barth.
+
+        Remove readonly keyword from the webkitIntent attribute. This is
+        needed otherwise the [Replaceable] extended attribute has not effect
+        with JSC. This is tested by webintents/web-intents-delivery-reuse.html
+        test case.
+
+        * Modules/intents/DOMWindowIntents.idl:
+
 2012-05-23  Abhishek Arya  <[email protected]>
 
         ASSERT failure toRenderProgress in HTMLProgressElement::didElementStateChange

Modified: trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl (118240 => 118241)


--- trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl	2012-05-23 20:52:42 UTC (rev 118240)
+++ trunk/Source/WebCore/Modules/intents/DOMWindowIntents.idl	2012-05-23 20:58:48 UTC (rev 118241)
@@ -32,7 +32,7 @@
     ] DOMWindowIntents {
         attribute IntentConstructor WebKitIntent;
 
-        readonly attribute [Replaceable] DeliveredIntent webkitIntent;
+        attribute [Replaceable] DeliveredIntent webkitIntent;
     };
 
 }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to