Title: [118274] trunk/Source/WebCore
- Revision
- 118274
- Author
- [email protected]
- Date
- 2012-05-23 17:12:16 -0700 (Wed, 23 May 2012)
Log Message
Unreviewed, rolling out r118129.
http://trac.webkit.org/changeset/118129
https://bugs.webkit.org/show_bug.cgi?id=87202
some LayoutTests crash since the patch passes a NULL to
Null(isolate)
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateFunctionCallback):
(NativeToJSValue):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::contentDocumentAttrGetter):
(WebCore::TestObjV8Internal::getSVGDocumentCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118273 => 118274)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 00:11:16 UTC (rev 118273)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 00:12:16 UTC (rev 118274)
@@ -1,5 +1,27 @@
2012-05-23 Kentaro Hara <[email protected]>
+ Unreviewed, rolling out r118129.
+ http://trac.webkit.org/changeset/118129
+ https://bugs.webkit.org/show_bug.cgi?id=87202
+
+ some LayoutTests crash since the patch passes a NULL to
+ Null(isolate)
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrGetter):
+ (GenerateFunctionCallback):
+ (NativeToJSValue):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::contentDocumentAttrGetter):
+ (WebCore::TestObjV8Internal::getSVGDocumentCallback):
+ * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
+ (WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetter):
+ (WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetter):
+ (WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetter):
+ (WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetter):
+
+2012-05-23 Kentaro Hara <[email protected]>
+
Unreviewed, rolling out r118133.
http://trac.webkit.org/changeset/118133
https://bugs.webkit.org/show_bug.cgi?id=87207
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (118273 => 118274)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-24 00:11:16 UTC (rev 118273)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2012-05-24 00:12:16 UTC (rev 118274)
@@ -842,7 +842,7 @@
# Generate security checks if necessary
if ($attribute->signature->extendedAttributes->{"CheckSecurityForNode"}) {
- push(@implContentDecls, " if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->" . $attribute->signature->name . "()))\n return v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));\n\n");
+ push(@implContentDecls, " if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->" . $attribute->signature->name . "()))\n return v8::Handle<v8::Value>(v8::Null());\n\n");
}
my $useExceptions = 1 if @{$attribute->getterExceptions};
@@ -1004,7 +1004,7 @@
my $getterFunc = $codeGenerator->WK_lcfirst($attribute->signature->name);
push(@implContentDecls, <<END);
SerializedScriptValue* serialized = imp->${getterFunc}();
- value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null());
info.Holder()->SetHiddenValue(propertyName, value);
return value;
END
@@ -1437,7 +1437,7 @@
if ($function->signature->extendedAttributes->{"CheckSecurityForNode"}) {
push(@implContentDecls, " if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->" . $function->signature->name . "(ec)))\n");
- push(@implContentDecls, " return v8::Handle<v8::Value>(v8::Null(args.GetIsolate()));\n");
+ push(@implContentDecls, " return v8::Handle<v8::Value>(v8::Null());\n");
END
}
@@ -3859,12 +3859,12 @@
if ($type eq "EventListener") {
AddToImplIncludes("V8AbstractEventListener.h");
- return "${value} ? v8::Handle<v8::Value>(static_cast<V8AbstractEventListener*>(${value})->getListenerObject(imp->scriptExecutionContext())) : v8::Handle<v8::Value>(v8::Null($getIsolate))";
+ return "${value} ? v8::Handle<v8::Value>(static_cast<V8AbstractEventListener*>(${value})->getListenerObject(imp->scriptExecutionContext())) : v8::Handle<v8::Value>(v8::Null())";
}
if ($type eq "SerializedScriptValue") {
AddToImplIncludes("$type.h");
- return "$value ? $value->deserialize() : v8::Handle<v8::Value>(v8::Null($getIsolate))";
+ return "$value ? $value->deserialize() : v8::Handle<v8::Value>(v8::Null())";
}
AddToImplIncludes("wtf/RefCounted.h");
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (118273 => 118274)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-24 00:11:16 UTC (rev 118273)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2012-05-24 00:12:16 UTC (rev 118274)
@@ -1134,7 +1134,7 @@
INC_STATS("DOM.TestObj.contentDocument._get");
TestObj* imp = V8TestObj::toNative(info.Holder());
if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->contentDocument()))
- return v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ return v8::Handle<v8::Value>(v8::Null());
return toV8(imp->contentDocument(), info.GetIsolate());
}
@@ -1904,7 +1904,7 @@
ExceptionCode ec = 0;
{
if (!V8BindingSecurity::shouldAllowAccessToNode(V8BindingState::Only(), imp->getSVGDocument(ec)))
- return v8::Handle<v8::Value>(v8::Null(args.GetIsolate()));
+ return v8::Handle<v8::Value>(v8::Null());
RefPtr<SVGDocument> result = imp->getSVGDocument(ec);
if (UNLIKELY(ec))
goto fail;
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp (118273 => 118274)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2012-05-24 00:11:16 UTC (rev 118273)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp 2012-05-24 00:12:16 UTC (rev 118274)
@@ -50,7 +50,7 @@
{
INC_STATS("DOM.TestSerializedScriptValueInterface.value._get");
TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(info.Holder());
- return imp->value() ? imp->value()->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ return imp->value() ? imp->value()->deserialize() : v8::Handle<v8::Value>(v8::Null());
}
static void valueAttrSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)
@@ -66,7 +66,7 @@
{
INC_STATS("DOM.TestSerializedScriptValueInterface.readonlyValue._get");
TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(info.Holder());
- return imp->readonlyValue() ? imp->readonlyValue()->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ return imp->readonlyValue() ? imp->readonlyValue()->deserialize() : v8::Handle<v8::Value>(v8::Null());
}
static v8::Handle<v8::Value> cachedValueAttrGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
@@ -78,7 +78,7 @@
return value;
TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(info.Holder());
SerializedScriptValue* serialized = imp->cachedValue();
- value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null());
info.Holder()->SetHiddenValue(propertyName, value);
return value;
}
@@ -116,7 +116,7 @@
return value;
TestSerializedScriptValueInterface* imp = V8TestSerializedScriptValueInterface::toNative(info.Holder());
SerializedScriptValue* serialized = imp->cachedReadonlyValue();
- value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate()));
+ value = serialized ? serialized->deserialize() : v8::Handle<v8::Value>(v8::Null());
info.Holder()->SetHiddenValue(propertyName, value);
return value;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
