Title: [118358] trunk
Revision
118358
Author
[email protected]
Date
2012-05-24 06:19:06 -0700 (Thu, 24 May 2012)

Log Message

Filter for RadioNodeList should be case sensitive.
https://bugs.webkit.org/show_bug.cgi?id=87369

Patch by Rakesh KN <[email protected]> on 2012-05-24
Reviewed by Kent Tamura.

Source/WebCore:

Element's id/name attribute matching criteria is case sensitive now.

Modified existing test.

* html/RadioNodeList.cpp:
(WebCore::RadioNodeList::nodeMatches):
Element matching criteria is case sensitive.

LayoutTests:

* fast/forms/form-collection-radio-node-list.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118357 => 118358)


--- trunk/LayoutTests/ChangeLog	2012-05-24 13:01:53 UTC (rev 118357)
+++ trunk/LayoutTests/ChangeLog	2012-05-24 13:19:06 UTC (rev 118358)
@@ -1,3 +1,12 @@
+2012-05-24  Rakesh KN  <[email protected]>
+
+        Filter for RadioNodeList should be case sensitive.
+        https://bugs.webkit.org/show_bug.cgi?id=87369
+
+        Reviewed by Kent Tamura.
+
+        * fast/forms/form-collection-radio-node-list.html:
+
 2012-05-24  Kristóf Kosztyó  <[email protected]>
 
         new test fast/js/dfg-arguments-mixed-alias.html fail on 32 bit linux

Modified: trunk/LayoutTests/fast/forms/form-collection-radio-node-list.html (118357 => 118358)


--- trunk/LayoutTests/fast/forms/form-collection-radio-node-list.html	2012-05-24 13:01:53 UTC (rev 118357)
+++ trunk/LayoutTests/fast/forms/form-collection-radio-node-list.html	2012-05-24 13:19:06 UTC (rev 118358)
@@ -10,7 +10,7 @@
     <input id=inputhidden type=hidden>
     <input id=commoninput type=text>
     <input id=inputcommon type=search value=searching>
-    <input id=inputurl type=url>
+    <input id=inputCOMMON type=url>
     <input id=commoninput type=email>
     <input id=inputpassword type=password>
     <input id=inputdate type=date>
@@ -30,7 +30,7 @@
     <object id=object1></object>
     <output id=output1></output>
     <progress id=progress1></progress>
-    <select id=select1>
+    <select id=select1 name=inputCOmmon>
         <optgroup id=optgroup1>group1</optgroup>
         <option id=option1>option1</option>
     </select>

Modified: trunk/Source/WebCore/ChangeLog (118357 => 118358)


--- trunk/Source/WebCore/ChangeLog	2012-05-24 13:01:53 UTC (rev 118357)
+++ trunk/Source/WebCore/ChangeLog	2012-05-24 13:19:06 UTC (rev 118358)
@@ -1,3 +1,18 @@
+2012-05-24  Rakesh KN  <[email protected]>
+
+        Filter for RadioNodeList should be case sensitive.
+        https://bugs.webkit.org/show_bug.cgi?id=87369
+
+        Reviewed by Kent Tamura.
+
+        Element's id/name attribute matching criteria is case sensitive now.
+
+        Modified existing test.
+
+        * html/RadioNodeList.cpp:
+        (WebCore::RadioNodeList::nodeMatches):
+        Element matching criteria is case sensitive.
+
 2012-05-23  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: add a command to InspectorMemoryAgent for getting process memory break down

Modified: trunk/Source/WebCore/html/RadioNodeList.cpp (118357 => 118358)


--- trunk/Source/WebCore/html/RadioNodeList.cpp	2012-05-24 13:01:53 UTC (rev 118357)
+++ trunk/Source/WebCore/html/RadioNodeList.cpp	2012-05-24 13:19:06 UTC (rev 118358)
@@ -96,7 +96,7 @@
             return false;
     }
 
-    return equalIgnoringCase(testElement->getIdAttribute(), m_name) || equalIgnoringCase(testElement->getNameAttribute(), m_name);
+    return testElement->getIdAttribute() ==  m_name || testElement->getNameAttribute() == m_name;
 }
 
 } // namspace
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to