Title: [118371] trunk/Source/WebCore
- Revision
- 118371
- Author
- [email protected]
- Date
- 2012-05-24 07:50:12 -0700 (Thu, 24 May 2012)
Log Message
Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
https://bugs.webkit.org/show_bug.cgi?id=87340
Patch by Vivek Galatage <[email protected]> on 2012-05-24
Reviewed by Pavel Feldman.
Removed the method _contextMenu as this would be redundant call
because _breakpointContextMenu would take care of showing the remove
all breakpoints option.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector._javascript_BreakpointsSidebarPane):
(WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointContextMenu):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118370 => 118371)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 14:43:31 UTC (rev 118370)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 14:50:12 UTC (rev 118371)
@@ -1,3 +1,18 @@
+2012-05-24 Vivek Galatage <[email protected]>
+
+ Web Inspector: Breakpoints Pane should not show context menu with no breakpoints
+ https://bugs.webkit.org/show_bug.cgi?id=87340
+
+ Reviewed by Pavel Feldman.
+
+ Removed the method _contextMenu as this would be redundant call
+ because _breakpointContextMenu would take care of showing the remove
+ all breakpoints option.
+
+ * inspector/front-end/BreakpointsSidebarPane.js:
+ (WebInspector._javascript_BreakpointsSidebarPane):
+ (WebInspector._javascript_BreakpointsSidebarPane.prototype._breakpointContextMenu):
+
2012-05-24 Yury Semikhatsky <[email protected]>
Unreviewed. Chromium Mac build fix after r118357.
Modified: trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js (118370 => 118371)
--- trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-05-24 14:43:31 UTC (rev 118370)
+++ trunk/Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js 2012-05-24 14:50:12 UTC (rev 118371)
@@ -43,7 +43,6 @@
this.emptyElement.textContent = WebInspector.UIString("No Breakpoints");
this.bodyElement.appendChild(this.emptyElement);
- this.bodyElement.addEventListener("contextmenu", this._contextMenu.bind(this), false);
this._items = new Map();
this._breakpointManager.addEventListener(WebInspector.BreakpointManager.Events.BreakpointAdded, this._breakpointAdded, this);
@@ -178,14 +177,6 @@
contextMenu.show(event);
},
- _contextMenu: function(event)
- {
- var contextMenu = new WebInspector.ContextMenu();
- var removeAllTitle = WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Remove all _javascript_ breakpoints" : "Remove All _javascript_ Breakpoints");
- contextMenu.appendItem(removeAllTitle, this._breakpointManager.removeAllBreakpoints.bind(this._breakpointManager));
- contextMenu.show(event);
- },
-
_addListElement: function(element, beforeElement)
{
if (beforeElement)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
