Title: [118379] trunk/Source/WebCore
- Revision
- 118379
- Author
- [email protected]
- Date
- 2012-05-24 08:31:07 -0700 (Thu, 24 May 2012)
Log Message
Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call
https://bugs.webkit.org/show_bug.cgi?id=87309
Reviewed by Nikolas Zimmermann.
This is a simple refactor that matches the work done in
https://bugs.webkit.org/show_bug.cgi?id=87309 to avoid an expensive call.
No new tests, no actual effects beyond performance improvement.
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::hasValidAttributeType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118378 => 118379)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 15:12:04 UTC (rev 118378)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 15:31:07 UTC (rev 118379)
@@ -1,3 +1,20 @@
+2012-05-24 Philip Rogers <[email protected]>
+
+ Refactor SVGAnimateTransformElement to avoid expensive determineAnimatedPropertyType call
+ https://bugs.webkit.org/show_bug.cgi?id=87309
+
+ Reviewed by Nikolas Zimmermann.
+
+ This is a simple refactor that matches the work done in
+ https://bugs.webkit.org/show_bug.cgi?id=87309 to avoid an expensive call.
+
+ No new tests, no actual effects beyond performance improvement.
+
+ * svg/SVGAnimateElement.h:
+ (SVGAnimateElement):
+ * svg/SVGAnimateTransformElement.cpp:
+ (WebCore::SVGAnimateTransformElement::hasValidAttributeType):
+
2012-05-24 Csaba Osztrogonác <[email protected]>
[Qt] Unreviewed trvial fixes.
Modified: trunk/Source/WebCore/svg/SVGAnimateElement.h (118378 => 118379)
--- trunk/Source/WebCore/svg/SVGAnimateElement.h 2012-05-24 15:12:04 UTC (rev 118378)
+++ trunk/Source/WebCore/svg/SVGAnimateElement.h 2012-05-24 15:31:07 UTC (rev 118379)
@@ -55,11 +55,12 @@
virtual void targetElementWillChange(SVGElement* currentTarget, SVGElement* oldTarget) OVERRIDE;
+ AnimatedPropertyType m_animatedPropertyType;
+
private:
SVGAnimatedTypeAnimator* ensureAnimator();
virtual bool hasValidAttributeType();
- AnimatedPropertyType m_animatedPropertyType;
OwnPtr<SVGAnimatedType> m_fromType;
OwnPtr<SVGAnimatedType> m_toType;
Modified: trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp (118378 => 118379)
--- trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp 2012-05-24 15:12:04 UTC (rev 118378)
+++ trunk/Source/WebCore/svg/SVGAnimateTransformElement.cpp 2012-05-24 15:31:07 UTC (rev 118379)
@@ -45,9 +45,11 @@
bool SVGAnimateTransformElement::hasValidAttributeType()
{
- if (SVGElement* targetElement = this->targetElement())
- return determineAnimatedPropertyType(targetElement) == AnimatedTransformList;
- return false;
+ SVGElement* targetElement = this->targetElement();
+ if (!targetElement)
+ return false;
+
+ return m_animatedPropertyType == AnimatedTransformList;
}
bool SVGAnimateTransformElement::isSupportedAttribute(const QualifiedName& attrName)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
