Title: [118399] trunk/Source/WebCore
Revision
118399
Author
[email protected]
Date
2012-05-24 11:57:14 -0700 (Thu, 24 May 2012)

Log Message

REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=87410

Reviewed by Anders Carlsson.

Do not pass a reference type to va_start (see r75435).

* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (118398 => 118399)


--- trunk/Source/WebCore/ChangeLog	2012-05-24 18:54:16 UTC (rev 118398)
+++ trunk/Source/WebCore/ChangeLog	2012-05-24 18:57:14 UTC (rev 118399)
@@ -1,3 +1,15 @@
+2012-05-24  Jessie Berlin  <[email protected]>
+
+        REGRESSION(r109663) All the the dom/html/level2/html/HTMLFrameElement* tests crash on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=87410
+
+        Reviewed by Anders Carlsson.
+
+        Do not pass a reference type to va_start (see r75435).
+
+        * platform/LocalizedStrings.cpp:
+        (WebCore::formatLocalizedString):
+
 2012-05-24  Yael Aharon  <[email protected]>
 
         [Qt] Stop using the flag FIXED_POSITION_CREATES_STACKING_CONTEXT

Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (118398 => 118399)


--- trunk/Source/WebCore/platform/LocalizedStrings.cpp	2012-05-24 18:54:16 UTC (rev 118398)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp	2012-05-24 18:57:14 UTC (rev 118399)
@@ -48,7 +48,7 @@
 //  2) It doesn't handle the %2$d syntax.
 // Note that because |format| is used as the second parameter to va_start, it cannot be a reference
 // type according to section 18.7/3 of the C++ N1905 standard.
-static String formatLocalizedString(const String& format, ...)
+static String formatLocalizedString(String format, ...)
 {
 #if USE(CF)
     va_list arguments;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to