Title: [118411] trunk/Source/WebCore
- Revision
- 118411
- Author
- [email protected]
- Date
- 2012-05-24 13:41:59 -0700 (Thu, 24 May 2012)
Log Message
MediaControlTimelineElement is adjusting time 3 times per click
https://bugs.webkit.org/show_bug.cgi?id=58160
Reviewed by Eric Carlson.
No new tests; we intentionally throttle timeupdate events for the same
movie time, so there is no way to write a layout test for this case.
Only call setCurrentTime() on mousedown or mousemove events.
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTimelineElement::defaultEventHandler):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118410 => 118411)
--- trunk/Source/WebCore/ChangeLog 2012-05-24 20:39:12 UTC (rev 118410)
+++ trunk/Source/WebCore/ChangeLog 2012-05-24 20:41:59 UTC (rev 118411)
@@ -1,3 +1,18 @@
+2012-05-24 Jer Noble <[email protected]>
+
+ MediaControlTimelineElement is adjusting time 3 times per click
+ https://bugs.webkit.org/show_bug.cgi?id=58160
+
+ Reviewed by Eric Carlson.
+
+ No new tests; we intentionally throttle timeupdate events for the same
+ movie time, so there is no way to write a layout test for this case.
+
+ Only call setCurrentTime() on mousedown or mousemove events.
+
+ * html/shadow/MediaControlElements.cpp:
+ (WebCore::MediaControlTimelineElement::defaultEventHandler):
+
2012-05-24 John Mellor <[email protected]>
Font Boosting: Add compile flag and runtime setting
Modified: trunk/Source/WebCore/html/shadow/MediaControlElements.cpp (118410 => 118411)
--- trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-05-24 20:39:12 UTC (rev 118410)
+++ trunk/Source/WebCore/html/shadow/MediaControlElements.cpp 2012-05-24 20:41:59 UTC (rev 118411)
@@ -869,8 +869,7 @@
return;
float time = narrowPrecisionToFloat(value().toDouble());
- if (time != mediaController()->currentTime()) {
- // FIXME: This is fired 3 times on every click. We should not be doing that <http:/webkit.org/b/58160>.
+ if (event->type() == eventNames().inputEvent && time != mediaController()->currentTime()) {
ExceptionCode ec;
mediaController()->setCurrentTime(time, ec);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
