Title: [118492] trunk
- Revision
- 118492
- Author
- [email protected]
- Date
- 2012-05-25 01:09:51 -0700 (Fri, 25 May 2012)
Log Message
Web Inspector: Resource object has no methods getContent and setContent
https://bugs.webkit.org/show_bug.cgi?id=87424
Source/WebCore:
This fixes the extension API so that it uses the `new Resource()`
constructor, which adds the missing `getContent` and `setContent`
methods to a `Resource` object.
Patch by Jan Keromnes <[email protected]> on 2012-05-25
Reviewed by Vsevolod Vlasov.
The tests were fixed accordingly in:
LayoutTests/inspector/extensions/extensions-resources-expected.txt
* inspector/front-end/ExtensionAPI.js:
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
(injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
LayoutTests:
This fixes the expected test result for `handleOpenResource()`, see fix
for bug #87424 in Source/WebCore/inspector/front-end/ExtensionAPI.js.
Patch by Jan Keromnes <[email protected]> on 2012-05-25
Reviewed by Vsevolod Vlasov.
* inspector/extensions/extensions-resources-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (118491 => 118492)
--- trunk/LayoutTests/ChangeLog 2012-05-25 08:00:35 UTC (rev 118491)
+++ trunk/LayoutTests/ChangeLog 2012-05-25 08:09:51 UTC (rev 118492)
@@ -1,3 +1,15 @@
+2012-05-25 Jan Keromnes <[email protected]>
+
+ Web Inspector: Resource object has no methods getContent and setContent
+ https://bugs.webkit.org/show_bug.cgi?id=87424
+
+ This fixes the expected test result for `handleOpenResource()`, see fix
+ for bug #87424 in Source/WebCore/inspector/front-end/ExtensionAPI.js.
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/extensions/extensions-resources-expected.txt:
+
2012-05-25 Vsevolod Vlasov <[email protected]>
Unreviewed chromium test expectations rebaseline.
Modified: trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt (118491 => 118492)
--- trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt 2012-05-25 08:00:35 UTC (rev 118491)
+++ trunk/LayoutTests/inspector/extensions/extensions-resources-expected.txt 2012-05-25 08:09:51 UTC (rev 118492)
@@ -74,6 +74,8 @@
0 : {
url : .../extensions-resources.html
type : "document"
+ getContent : <function>
+ setContent : <function>
}
1 : 11
}
Modified: trunk/Source/WebCore/ChangeLog (118491 => 118492)
--- trunk/Source/WebCore/ChangeLog 2012-05-25 08:00:35 UTC (rev 118491)
+++ trunk/Source/WebCore/ChangeLog 2012-05-25 08:09:51 UTC (rev 118492)
@@ -1,3 +1,21 @@
+2012-05-25 Jan Keromnes <[email protected]>
+
+ Web Inspector: Resource object has no methods getContent and setContent
+ https://bugs.webkit.org/show_bug.cgi?id=87424
+
+ This fixes the extension API so that it uses the `new Resource()`
+ constructor, which adds the missing `getContent` and `setContent`
+ methods to a `Resource` object.
+
+ Reviewed by Vsevolod Vlasov.
+
+ The tests were fixed accordingly in:
+ LayoutTests/inspector/extensions/extensions-resources-expected.txt
+
+ * inspector/front-end/ExtensionAPI.js:
+ (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler.else.callbackWrapper):
+ (injectedExtensionAPI.Panels.prototype.setOpenResourceHandler):
+
2012-05-24 Tim Horton <[email protected]>
Add feature defines for web-facing parts of CSS Regions and Exclusions
Modified: trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js (118491 => 118492)
--- trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2012-05-25 08:00:35 UTC (rev 118491)
+++ trunk/Source/WebCore/inspector/front-end/ExtensionAPI.js 2012-05-25 08:09:51 UTC (rev 118492)
@@ -305,7 +305,7 @@
else {
function callbackWrapper(message)
{
- callback.call(null, message.resource, message.lineNumber);
+ callback.call(null, new Resource(message.resource), message.lineNumber);
}
extensionServer.registerHandler(events.OpenResource, callbackWrapper);
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
