Title: [118509] trunk/Source/WebCore
Revision
118509
Author
[email protected]
Date
2012-05-25 03:15:57 -0700 (Fri, 25 May 2012)

Log Message

Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates.
https://bugs.webkit.org/show_bug.cgi?id=87482

Engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable.

Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.classIndex):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (118508 => 118509)


--- trunk/Source/WebCore/ChangeLog	2012-05-25 10:09:21 UTC (rev 118508)
+++ trunk/Source/WebCore/ChangeLog	2012-05-25 10:15:57 UTC (rev 118509)
@@ -1,3 +1,15 @@
+2012-05-25  Ilya Tikhonovsky  <[email protected]>
+
+        Web Inspector: HeapProfiler: speed-up _calculateClassesRetainedSize and _buildAggregates.
+        https://bugs.webkit.org/show_bug.cgi?id=87482
+
+        Engine didn't inline node's classIndex method because the switch statement in it wasn't inlineable.
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (WebInspector.HeapSnapshotNode.prototype.classIndex):
+
 2012-05-24  Andreas Kling  <[email protected]>
 
         Dodge style recalc when id attribute is overwritten with same value.

Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js (118508 => 118509)


--- trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-05-25 10:09:21 UTC (rev 118508)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js	2012-05-25 10:15:57 UTC (rev 118509)
@@ -456,13 +456,9 @@
         var snapshot = this._snapshot;
         var nodes = snapshot._nodes;
         var type = nodes[this.nodeIndex + snapshot._nodeTypeOffset];;
-        switch (type) {
-        case snapshot._nodeObjectType:
-        case snapshot._nodeNativeType:
+        if (type === snapshot._nodeObjectType || type === snapshot._nodeNativeType)
             return nodes[this.nodeIndex + snapshot._nodeNameOffset];
-        default:
-            return -1 - type;
-        }
+        return -1 - type;
     },
 
     dominatorIndex: function()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to