Title: [118523] trunk
- Revision
- 118523
- Author
- [email protected]
- Date
- 2012-05-25 06:48:08 -0700 (Fri, 25 May 2012)
Log Message
Web Inspector: HeapSnapshot: introduce performance counter for HeapSnapshotConstructorsDataGrid._aggregatesReceived method.
https://bugs.webkit.org/show_bug.cgi?id=87393
Reviewed by Yury Semikhatsky.
PerformanceTests:
* inspector/heap-snapshot.html:
Source/WebCore:
* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._aggregatesReceived):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):
Modified Paths
Diff
Modified: trunk/PerformanceTests/ChangeLog (118522 => 118523)
--- trunk/PerformanceTests/ChangeLog 2012-05-25 13:45:26 UTC (rev 118522)
+++ trunk/PerformanceTests/ChangeLog 2012-05-25 13:48:08 UTC (rev 118523)
@@ -1,5 +1,14 @@
2012-05-25 Ilya Tikhonovsky <[email protected]>
+ Web Inspector: HeapSnapshot: introduce performance counter for HeapSnapshotConstructorsDataGrid._aggregatesReceived method.
+ https://bugs.webkit.org/show_bug.cgi?id=87393
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/heap-snapshot.html:
+
+2012-05-25 Ilya Tikhonovsky <[email protected]>
+
Web Inspector: HeapProfiler's perf test: each N-th run pushes the run results N-th times.
https://bugs.webkit.org/show_bug.cgi?id=87476
Modified: trunk/PerformanceTests/inspector/heap-snapshot.html (118522 => 118523)
--- trunk/PerformanceTests/inspector/heap-snapshot.html 2012-05-25 13:45:26 UTC (rev 118522)
+++ trunk/PerformanceTests/inspector/heap-snapshot.html 2012-05-25 13:48:08 UTC (rev 118523)
@@ -20,6 +20,7 @@
InspectorTest.measureFunction(WebInspector.HeapSnapshot.prototype, "_splitNodesAndContainmentEdges");
InspectorTest.measureFunction(WebInspector.HeapSnapshot.prototype, "_buildPostOrderIndex");
InspectorTest.measureFunction(WebInspector.HeapSnapshot.prototype, "_buildDominatorTree");
+ InspectorTest.measureFunction(WebInspector.HeapSnapshotConstructorsDataGrid.prototype, "_aggregatesReceived");
function performanceTest(timer)
{
Modified: trunk/Source/WebCore/ChangeLog (118522 => 118523)
--- trunk/Source/WebCore/ChangeLog 2012-05-25 13:45:26 UTC (rev 118522)
+++ trunk/Source/WebCore/ChangeLog 2012-05-25 13:48:08 UTC (rev 118523)
@@ -1,5 +1,16 @@
2012-05-25 Ilya Tikhonovsky <[email protected]>
+ Web Inspector: HeapSnapshot: introduce performance counter for HeapSnapshotConstructorsDataGrid._aggregatesReceived method.
+ https://bugs.webkit.org/show_bug.cgi?id=87393
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/HeapSnapshotDataGrids.js:
+ (WebInspector.HeapSnapshotConstructorsDataGrid.prototype._aggregatesReceived):
+ (WebInspector.HeapSnapshotConstructorsDataGrid.prototype._populateChildren):
+
+2012-05-25 Ilya Tikhonovsky <[email protected]>
+
Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric.
https://bugs.webkit.org/show_bug.cgi?id=87490
@@ -16,6 +27,24 @@
(WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
(WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
+2012-05-25 Ilya Tikhonovsky <[email protected]>
+
+ Web Inspector: drop obsolete WebInspector.Uint32Array and adjust snapshot chunk size for better transfer-snapshot metric.
+ https://bugs.webkit.org/show_bug.cgi?id=87490
+
+ Originally WebInspector.Uint32Array was used for dynamic array
+ reallocation because we had no information about expected arrays sizes.
+ Now we have these sizes and allocates array precisely.
+
+ Reviewed by Yury Semikhatsky.
+
+ * bindings/v8/ScriptHeapSnapshot.cpp:
+ (WebCore):
+ * inspector/front-end/HeapSnapshot.js:
+ * inspector/front-end/HeapSnapshotLoader.js:
+ (WebInspector.HeapSnapshotLoader.prototype._parseUintArray):
+ (WebInspector.HeapSnapshotLoader.prototype.pushJSONChunk):
+
2012-05-25 Alexander Pavlov <[email protected]>
Web Inspector: cmd-[ shortcut navigates page and is fr-keyboard incompatible
Modified: trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js (118522 => 118523)
--- trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-05-25 13:45:26 UTC (rev 118522)
+++ trunk/Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js 2012-05-25 13:48:08 UTC (rev 118523)
@@ -558,14 +558,15 @@
}
},
+ _aggregatesReceived: function(key, aggregates)
+ {
+ for (var constructor in aggregates)
+ this.appendTopLevelNode(new WebInspector.HeapSnapshotConstructorNode(this, constructor, aggregates[constructor], key));
+ this.sortingChanged();
+ },
+
_populateChildren: function()
{
- function aggregatesReceived(key, aggregates)
- {
- for (var constructor in aggregates)
- this.appendTopLevelNode(new WebInspector.HeapSnapshotConstructorNode(this, constructor, aggregates[constructor], key));
- this.sortingChanged();
- }
this.dispose();
this.removeTopLevelNodes();
@@ -574,7 +575,7 @@
var key = this._profileIndex === -1 ? "allObjects" : this._minNodeId + ".." + this._maxNodeId;
var filter = this._profileIndex === -1 ? null : "function(node) { var id = node.id(); return id > " + this._minNodeId + " && id <= " + this._maxNodeId + "; }";
- this.snapshot.aggregates(false, key, filter, aggregatesReceived.bind(this, key));
+ this.snapshot.aggregates(false, key, filter, this._aggregatesReceived.bind(this, key));
},
_filterSelectIndexChanged: function(profiles, profileIndex)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
