Title: [118625] trunk/Source/WebKit/blackberry
- Revision
- 118625
- Author
- [email protected]
- Date
- 2012-05-27 07:17:58 -0700 (Sun, 27 May 2012)
Log Message
[BlackBerry] Web page fails to render after clicking link with target=_blank
https://bugs.webkit.org/show_bug.cgi?id=87562
Patch by Arvid Nilsson <[email protected]> on 2012-04-12
Reviewed by Antonio Gomes.
Clicking such a link opens a new tab. The compositor was briefly in
charge of drawing the root layer while the backing store was inactive
and the user was looking at the other tab. The problem was that the
compositor believed it was still painting the root layer even after the
backing store became active again. The flag was not properly cleared
when turning off compositing.
Fixed by returning false from drawsRootLayer() if we don't have a root
layer.
Reviewed internally by Filip Spacek.
PR #149342
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp (118624 => 118625)
--- trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-05-27 11:35:40 UTC (rev 118624)
+++ trunk/Source/WebKit/blackberry/Api/WebPageCompositor.cpp 2012-05-27 14:17:58 UTC (rev 118625)
@@ -109,7 +109,7 @@
bool WebPageCompositorPrivate::drawsRootLayer() const
{
- return m_drawsRootLayer;
+ return m_rootLayer && m_drawsRootLayer;
}
bool WebPageCompositorPrivate::drawLayers(const IntRect& dstRect, const FloatRect& contents)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (118624 => 118625)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-05-27 11:35:40 UTC (rev 118624)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-05-27 14:17:58 UTC (rev 118625)
@@ -1,3 +1,29 @@
+2012-05-27 Arvid Nilsson <[email protected]>
+
+ 2012-04-12 Arvid Nilsson <[email protected]>
+
+ [BlackBerry] Web page fails to render after clicking link with target=_blank
+ https://bugs.webkit.org/show_bug.cgi?id=87562
+
+ Reviewed by Antonio Gomes.
+
+ Clicking such a link opens a new tab. The compositor was briefly in
+ charge of drawing the root layer while the backing store was inactive
+ and the user was looking at the other tab. The problem was that the
+ compositor believed it was still painting the root layer even after the
+ backing store became active again. The flag was not properly cleared
+ when turning off compositing.
+
+ Fixed by returning false from drawsRootLayer() if we don't have a root
+ layer.
+
+ Reviewed internally by Filip Spacek.
+
+ PR #149342
+
+ * Api/WebPageCompositor.cpp:
+ (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer):
+
2012-05-24 Jacky Jiang <[email protected]>
[BlackBerry] History navigation caused google.com scale not kept
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
