Title: [118633] trunk/LayoutTests
Revision
118633
Author
[email protected]
Date
2012-05-27 17:28:49 -0700 (Sun, 27 May 2012)

Log Message

fast/dom/shadow/content-element-in-media.html is wrong.
https://bugs.webkit.org/show_bug.cgi?id=81310

Modifying to check() to dump expected and actual text at the same
absolute position, because DumpRenderTree dumps absolute x,y-position
information for a layer which contains RenderVideo. For example,
backgroundClip at (8,163), clip at (8, 163) and so on.

Patch by Takashi Sakamoto <[email protected]> on 2012-05-27
Reviewed by Hajime Morita.

* fast/dom/resources/shadow-test-driver.js:
(check):
Disabled actual block when dumping expected block as text, and vice
versa.
* platform/chromium/test_expectations.txt:
Removed BUGWK81310.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118632 => 118633)


--- trunk/LayoutTests/ChangeLog	2012-05-28 00:23:25 UTC (rev 118632)
+++ trunk/LayoutTests/ChangeLog	2012-05-28 00:28:49 UTC (rev 118633)
@@ -1,3 +1,22 @@
+2012-05-27  Takashi Sakamoto  <[email protected]>
+
+        fast/dom/shadow/content-element-in-media.html is wrong.
+        https://bugs.webkit.org/show_bug.cgi?id=81310
+
+        Modifying to check() to dump expected and actual text at the same
+        absolute position, because DumpRenderTree dumps absolute x,y-position
+        information for a layer which contains RenderVideo. For example,
+        backgroundClip at (8,163), clip at (8, 163) and so on.
+
+        Reviewed by Hajime Morita.
+
+        * fast/dom/resources/shadow-test-driver.js:
+        (check):
+        Disabled actual block when dumping expected block as text, and vice
+        versa.
+        * platform/chromium/test_expectations.txt:
+        Removed BUGWK81310.
+
 2012-05-27  Benjamin Poulain  <[email protected]>
 
         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called

Modified: trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js (118632 => 118633)


--- trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js	2012-05-28 00:23:25 UTC (rev 118632)
+++ trunk/LayoutTests/fast/dom/resources/shadow-test-driver.js	2012-05-28 00:28:49 UTC (rev 118633)
@@ -36,11 +36,21 @@
 }
 
 function check() {
-    var refContainerRenderTree = internals.elementRenderTreeAsText(document.getElementById('expect-container'));
+    var expectContainer = document.getElementById('expect-container');
+    var actualContainer = document.getElementById('actual-container');
+    var originalDisplayValue = actualContainer.style.display;
+    actualContainer.style.display = 'none';
+    expectContainer.offsetLeft;
+    var refContainerRenderTree = internals.elementRenderTreeAsText(expectContainer);
     var refRenderTree = removeContainerLines(refContainerRenderTree);
+    actualContainer.style.display = originalDisplayValue;
 
-    var targetContainerRenderTree = internals.elementRenderTreeAsText(document.getElementById('actual-container'));
+    originalDisplayValue = expectContainer.style.display;
+    expectContainer.style.display = 'none';
+    actualContainer.offsetLeft;
+    var targetContainerRenderTree = internals.elementRenderTreeAsText(actualContainer);
     var targetRenderTree = removeContainerLines(targetContainerRenderTree);
+    expectContainer.style.display = originalDisplayValue;
 
     if (targetRenderTree == refRenderTree)
         log("PASS");

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (118632 => 118633)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-28 00:23:25 UTC (rev 118632)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2012-05-28 00:28:49 UTC (rev 118633)
@@ -2741,8 +2741,6 @@
 
 BUGCR85292 : platform/chromium/permissionclient/storage-permission.html = PASS TEXT
 
-BUGWK81310 : fast/dom/shadow/content-element-in-media-element.html = TEXT
-
 // two regions reftests failing on Chromium
 BUGWK74219 : fast/regions/positioned-objects-block-static-spanning-regions-rtl.html = PASS IMAGE
 BUGWK74219 : fast/regions/positioned-objects-block-static-spanning-regions.html = PASS IMAGE
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to