Title: [118664] trunk/Source/WebCore
- Revision
- 118664
- Author
- [email protected]
- Date
- 2012-05-28 02:54:00 -0700 (Mon, 28 May 2012)
Log Message
HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
https://bugs.webkit.org/show_bug.cgi?id=87608
Reviewed by Kent Tamura.
Moved m_validationMessage clearance from detach() to removedFrom() and
remove detach().
No new tests. This change has no visible difference. Upcoming changes rely on this though.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::removedFrom):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118663 => 118664)
--- trunk/Source/WebCore/ChangeLog 2012-05-28 09:49:31 UTC (rev 118663)
+++ trunk/Source/WebCore/ChangeLog 2012-05-28 09:54:00 UTC (rev 118664)
@@ -1,3 +1,18 @@
+2012-05-28 MORITA Hajime <[email protected]>
+
+ HTMLFormControlElement::m_validationMessage shouldn't be cleared on detach()
+ https://bugs.webkit.org/show_bug.cgi?id=87608
+
+ Reviewed by Kent Tamura.
+
+ Moved m_validationMessage clearance from detach() to removedFrom() and
+ remove detach().
+
+ No new tests. This change has no visible difference. Upcoming changes rely on this though.
+
+ * html/HTMLFormControlElement.cpp:
+ (WebCore::HTMLFormControlElement::removedFrom):
+
2012-05-28 Yury Semikhatsky <[email protected]>
Web Inspector: "Record CPU profile" button doesn't change its state after finishing profiling
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (118663 => 118664)
--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-05-28 09:49:31 UTC (rev 118663)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.cpp 2012-05-28 09:54:00 UTC (rev 118664)
@@ -70,12 +70,6 @@
{
}
-void HTMLFormControlElement::detach()
-{
- m_validationMessage = nullptr;
- HTMLElement::detach();
-}
-
String HTMLFormControlElement::formEnctype() const
{
return FormSubmission::Attributes::parseEncodingType(fastGetAttribute(formenctypeAttr));
@@ -233,6 +227,7 @@
void HTMLFormControlElement::removedFrom(ContainerNode* insertionPoint)
{
+ m_validationMessage = nullptr;
m_fieldSetAncestorValid = false;
m_dataListAncestorState = Unknown;
HTMLElement::removedFrom(insertionPoint);
Modified: trunk/Source/WebCore/html/HTMLFormControlElement.h (118663 => 118664)
--- trunk/Source/WebCore/html/HTMLFormControlElement.h 2012-05-28 09:49:31 UTC (rev 118663)
+++ trunk/Source/WebCore/html/HTMLFormControlElement.h 2012-05-28 09:54:00 UTC (rev 118664)
@@ -130,7 +130,6 @@
virtual void didRecalcStyle(StyleChange) OVERRIDE;
virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode);
- virtual void detach();
// This must be called any time the result of willValidate() has changed.
void setNeedsWillValidateCheck();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
