[webkit-changes] [118672] trunk

Mon, 28 May 2012 03:24:10 -0700

Title: [118672] trunk
Revision
118672
Author
[email protected]
Date
2012-05-28 03:23:41 -0700 (Mon, 28 May 2012)

Log Message

&AElig doesn't get rendered as U+00C6
https://bugs.webkit.org/show_bug.cgi?id=87465

Reviewed by Adam Barth.

Source/WebCore:

The if-statement to check whether the first entry of a certain letter
already exists in the index used .get(). The very first alphabetical
entry is in position "0", which evaluates to false, causing the first
entry to be ignored. Instead, use a "x not in y" check here.

Also update WebCore.gyp to list the create-html-entity-table script as
an input for the action, to make sure the table will be recreated.

Test: html5lib/resources/entities02.dat

* WebCore.gyp/WebCore.gyp:
* html/parser/create-html-entity-table:

LayoutTests:

Test that the (current) first alphabetical entity in the named entity
table (&AElig, without a semi-colon) renders as expected.

* html5lib/resources/entities02.dat:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118671 => 118672)


--- trunk/LayoutTests/ChangeLog	2012-05-28 10:21:31 UTC (rev 118671)
+++ trunk/LayoutTests/ChangeLog	2012-05-28 10:23:41 UTC (rev 118672)
@@ -1,3 +1,15 @@
+2012-05-28  Peter Beverloo  <[email protected]>
+
+        &AElig doesn't get rendered as U+00C6
+        https://bugs.webkit.org/show_bug.cgi?id=87465
+
+        Reviewed by Adam Barth.
+
+        Test that the (current) first alphabetical entity in the named entity
+        table (&AElig, without a semi-colon) renders as expected.
+
+        * html5lib/resources/entities02.dat:
+
 2012-05-28  Christophe Dumez  <[email protected]>
 
         [EFL] fast/dom/beforeload/image-object-before-load* need to be skipped after r118618

Modified: trunk/LayoutTests/html5lib/resources/entities02.dat (118671 => 118672)


--- trunk/LayoutTests/html5lib/resources/entities02.dat	2012-05-28 10:21:31 UTC (rev 118671)
+++ trunk/LayoutTests/html5lib/resources/entities02.dat	2012-05-28 10:23:41 UTC (rev 118672)
@@ -247,3 +247,13 @@
 |   <body>
 |     <div>
 |       "ZZ&prod=23"
+
+#data
+<div>ZZ&AElig=</div>
+#errors
+#document
+| <html>
+|   <head>
+|   <body>
+|     <div>
+|       "ZZÆ="

Modified: trunk/Source/WebCore/ChangeLog (118671 => 118672)


--- trunk/Source/WebCore/ChangeLog	2012-05-28 10:21:31 UTC (rev 118671)
+++ trunk/Source/WebCore/ChangeLog	2012-05-28 10:23:41 UTC (rev 118672)
@@ -1,3 +1,23 @@
+2012-05-28  Peter Beverloo  <[email protected]>
+
+        &AElig doesn't get rendered as U+00C6
+        https://bugs.webkit.org/show_bug.cgi?id=87465
+
+        Reviewed by Adam Barth.
+
+        The if-statement to check whether the first entry of a certain letter
+        already exists in the index used .get(). The very first alphabetical
+        entry is in position "0", which evaluates to false, causing the first
+        entry to be ignored. Instead, use a "x not in y" check here.
+
+        Also update WebCore.gyp to list the create-html-entity-table script as
+        an input for the action, to make sure the table will be recreated.
+
+        Test: html5lib/resources/entities02.dat
+
+        * WebCore.gyp/WebCore.gyp:
+        * html/parser/create-html-entity-table:
+
 2012-05-28  Yury Semikhatsky  <[email protected]>
 
         Web Inspector: dom counters graphs vanish on switching between timeline views

Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (118671 => 118672)


--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-05-28 10:21:31 UTC (rev 118671)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp	2012-05-28 10:23:41 UTC (rev 118672)
@@ -575,6 +575,7 @@
         {
           'action_name': 'HTMLEntityTable',
           'inputs': [
+            '../html/parser/create-html-entity-table',
             '../html/parser/HTMLEntityNames.in',
           ],
           'outputs': [

Modified: trunk/Source/WebCore/html/parser/create-html-entity-table (118671 => 118672)


--- trunk/Source/WebCore/html/parser/create-html-entity-table	2012-05-28 10:21:31 UTC (rev 118671)
+++ trunk/Source/WebCore/html/parser/create-html-entity-table	2012-05-28 10:23:41 UTC (rev 118672)
@@ -124,7 +124,7 @@
 offset = 0
 for entry in entries:
     letter = entry[ENTITY][0]
-    if not index.get(letter):
+    if letter not in index:
         index[letter] = offset
     values = entry[VALUE].split(' ')
     assert len(values) <= 2, values

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to