Title: [118737] trunk
Revision
118737
Author
[email protected]
Date
2012-05-29 02:01:34 -0700 (Tue, 29 May 2012)

Log Message

Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
https://bugs.webkit.org/show_bug.cgi?id=87708

Reviewed by Adam Barth.

Source/WebCore:

Lots of tests in fast/frames/seamless cover this property.

* html/HTMLIFrameElement.idl:

LayoutTests:

* fast/frames/seamless/seamless-basic-expected.txt:
* fast/frames/seamless/seamless-inherited-origin-expected.txt:
* fast/frames/seamless/seamless-nested-expected.txt:
* fast/frames/seamless/seamless-quirks-expected.txt:
* fast/frames/seamless/seamless-sandbox-flag-expected.txt:
* fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
* http/tests/security/seamless/seamless-cross-origin-expected.txt:
* http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (118736 => 118737)


--- trunk/LayoutTests/ChangeLog	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/ChangeLog	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,3 +1,19 @@
+2012-05-29  Eric Seidel  <[email protected]>
+
+        Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
+        https://bugs.webkit.org/show_bug.cgi?id=87708
+
+        Reviewed by Adam Barth.
+
+        * fast/frames/seamless/seamless-basic-expected.txt:
+        * fast/frames/seamless/seamless-inherited-origin-expected.txt:
+        * fast/frames/seamless/seamless-nested-expected.txt:
+        * fast/frames/seamless/seamless-quirks-expected.txt:
+        * fast/frames/seamless/seamless-sandbox-flag-expected.txt:
+        * fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt:
+        * http/tests/security/seamless/seamless-cross-origin-expected.txt:
+        * http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt:
+
 2012-05-29  Nikolas Zimmermann  <[email protected]>
 
         SVGViewSpec DOM bindings aka SVGSVGElement.currentView is unimplemented

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-basic-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-basic-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-basic-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,5 +1,5 @@
 Test basic seamless auto-sizing-to-content functionality.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
 PASS window.getComputedStyle(iframe).display is "block"
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "100px"

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-inherited-origin-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-inherited-origin-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-inherited-origin-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,5 +1,5 @@
 Test that frames with inherited security origins can still be seamless.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "8px"
 PASS window.getComputedStyle(iframe).width is "200px"

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-nested-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-nested-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-nested-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,6 +1,6 @@
 Test that nested seamless iframes size correctly.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
-FAIL nestedFrame.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
+PASS nestedFrame.seamless is true
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "100px"
 

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-quirks-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-quirks-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-quirks-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,5 +1,5 @@
 Test that a quirks-mode document inside a seamless iframe sizes correctly.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
 PASS iframe.contentDocument.compatMode is "BackCompat"
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "100px"

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-flag-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-flag-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-flag-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,6 +1,6 @@
 Test that sandbox disables nested seamless iframes correctly.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
-FAIL nestedFrame.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
+PASS nestedFrame.seamless is true
 PASS window.getComputedStyle(iframe).display is "block"
 PASS window.getComputedStyle(iframe).borderWidth is "0px"
 PASS window.getComputedStyle(iframe).borderStyle is "none"

Modified: trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt (118736 => 118737)


--- trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,5 +1,5 @@
 Test that iframes with srcdoc contents can still be seamless.
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "100px"
 

Modified: trunk/LayoutTests/http/tests/security/seamless/seamless-cross-origin-expected.txt (118736 => 118737)


--- trunk/LayoutTests/http/tests/security/seamless/seamless-cross-origin-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/http/tests/security/seamless/seamless-cross-origin-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,5 +1,5 @@
-FAIL iframe1.seamless should be true (of type boolean). Was undefined (of type undefined).
-FAIL iframe2.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe1.seamless is true
+PASS iframe2.seamless is true
 PASS window.getComputedStyle(iframe1).width is "200px"
 PASS window.getComputedStyle(iframe1).height is "100px"
 PASS window.getComputedStyle(iframe2).width is "300px"

Modified: trunk/LayoutTests/http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt (118736 => 118737)


--- trunk/LayoutTests/http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/LayoutTests/http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,4 +1,4 @@
-FAIL iframe.seamless should be true (of type boolean). Was undefined (of type undefined).
+PASS iframe.seamless is true
 PASS window.getComputedStyle(iframe).width is "200px"
 PASS window.getComputedStyle(iframe).height is "100px"
 

Modified: trunk/Source/WebCore/ChangeLog (118736 => 118737)


--- trunk/Source/WebCore/ChangeLog	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/Source/WebCore/ChangeLog	2012-05-29 09:01:34 UTC (rev 118737)
@@ -1,3 +1,14 @@
+2012-05-29  Eric Seidel  <[email protected]>
+
+        Add HTMLIFrameElement.seamless property accessor now that seamless is enabled and works
+        https://bugs.webkit.org/show_bug.cgi?id=87708
+
+        Reviewed by Adam Barth.
+
+        Lots of tests in fast/frames/seamless cover this property.
+
+        * html/HTMLIFrameElement.idl:
+
 2012-05-29  Kentaro Hara  <[email protected]>
 
         [Performance] Optimize querySelector() and querySelectorAll() by removing

Modified: trunk/Source/WebCore/html/HTMLIFrameElement.idl (118736 => 118737)


--- trunk/Source/WebCore/html/HTMLIFrameElement.idl	2012-05-29 08:43:40 UTC (rev 118736)
+++ trunk/Source/WebCore/html/HTMLIFrameElement.idl	2012-05-29 09:01:34 UTC (rev 118737)
@@ -29,6 +29,7 @@
         attribute [Reflect] DOMString marginWidth;
         attribute [Reflect] DOMString name;
         attribute [Reflect] DOMString sandbox;
+        attribute [Reflect, Conditional=IFRAME_SEAMLESS] boolean seamless;
         attribute [Reflect] DOMString scrolling;
         attribute [Reflect, URL] DOMString src;
         attribute [Reflect] DOMString srcdoc;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to