Title: [118796] trunk/Source/WebKit2
- Revision
- 118796
- Author
- [email protected]
- Date
- 2012-05-29 09:48:54 -0700 (Tue, 29 May 2012)
Log Message
[GTK] [WK2] Reproducible crash in performDragControllerAction
https://bugs.webkit.org/show_bug.cgi?id=87744
Patch by Sudarsana Nagineni <[email protected]> on 2012-05-29
Reviewed by Martin Robinson.
Fix a crash by using deref() instead of delete to dereference and
release the platformData of DragData.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (118795 => 118796)
--- trunk/Source/WebKit2/ChangeLog 2012-05-29 16:47:03 UTC (rev 118795)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-29 16:48:54 UTC (rev 118796)
@@ -1,3 +1,16 @@
+2012-05-29 Sudarsana Nagineni <[email protected]>
+
+ [GTK] [WK2] Reproducible crash in performDragControllerAction
+ https://bugs.webkit.org/show_bug.cgi?id=87744
+
+ Reviewed by Martin Robinson.
+
+ Fix a crash by using deref() instead of delete to dereference and
+ release the platformData of DragData.
+
+ * WebProcess/WebPage/WebPage.cpp:
+ (WebKit::WebPage::performDragControllerAction):
+
2012-05-29 Simon Pena <[email protected]>
[GTK] Missing field initializers for WKPageLoaderClient and WKPageUIClient
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (118795 => 118796)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-05-29 16:47:03 UTC (rev 118795)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-05-29 16:48:54 UTC (rev 118796)
@@ -2146,10 +2146,11 @@
send(Messages::WebPageProxy::DidPerformDragControllerAction(WebCore::DragSession()));
#if PLATFORM(QT)
QMimeData* data = ""
+ delete data;
#elif PLATFORM(GTK)
DataObjectGtk* data = ""
+ data->deref();
#endif
- delete data;
return;
}
@@ -2177,10 +2178,11 @@
// DragData does not delete its platformData so we need to do that here.
#if PLATFORM(QT)
QMimeData* data = ""
+ delete data;
#elif PLATFORM(GTK)
DataObjectGtk* data = ""
+ data->deref();
#endif
- delete data;
}
#else
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
