Title: [118888] trunk/Source/WebCore
- Revision
- 118888
- Author
- [email protected]
- Date
- 2012-05-29 21:03:07 -0700 (Tue, 29 May 2012)
Log Message
Fix inefficient usage of traverseNextNode()
https://bugs.webkit.org/show_bug.cgi?id=87804
Reviewed by Ryosuke Niwa.
foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
firstChild() is more efficient.
No new tests because of no behavior change.
* html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
Replace traverseNextNode() with firstChild(), and shorten a variable name.
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getElementById):
Replace traverseNextNode() with firstChild().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (118887 => 118888)
--- trunk/Source/WebCore/ChangeLog 2012-05-30 03:51:23 UTC (rev 118887)
+++ trunk/Source/WebCore/ChangeLog 2012-05-30 04:03:07 UTC (rev 118888)
@@ -1,3 +1,22 @@
+2012-05-29 Kent Tamura <[email protected]>
+
+ Fix inefficient usage of traverseNextNode()
+ https://bugs.webkit.org/show_bug.cgi?id=87804
+
+ Reviewed by Ryosuke Niwa.
+
+ foo->traverseNextNode(foo) is equivalent to foo->firstChild(), and
+ firstChild() is more efficient.
+
+ No new tests because of no behavior change.
+
+ * html/HTMLFieldSetElement.cpp:
+ (WebCore::HTMLFieldSetElement::invalidateDisabledStateUnder):
+ Replace traverseNextNode() with firstChild(), and shorten a variable name.
+ * svg/SVGSVGElement.cpp:
+ (WebCore::SVGSVGElement::getElementById):
+ Replace traverseNextNode() with firstChild().
+
2012-05-29 Jonathan Dong <[email protected]>
[BlackBerry] Loading media data with http authentication
Modified: trunk/Source/WebCore/html/HTMLFieldSetElement.cpp (118887 => 118888)
--- trunk/Source/WebCore/html/HTMLFieldSetElement.cpp 2012-05-30 03:51:23 UTC (rev 118887)
+++ trunk/Source/WebCore/html/HTMLFieldSetElement.cpp 2012-05-30 04:03:07 UTC (rev 118888)
@@ -49,9 +49,9 @@
void HTMLFieldSetElement::invalidateDisabledStateUnder(Element* base)
{
- for (Node* currentNode = base->traverseNextNode(base); currentNode; currentNode = currentNode->traverseNextNode(base)) {
- if (currentNode && currentNode->isElementNode() && toElement(currentNode)->isFormControlElement())
- static_cast<HTMLFormControlElement*>(currentNode)->ancestorDisabledStateWasChanged();
+ for (Node* node = base->firstChild(); node; node = node->traverseNextNode(base)) {
+ if (node->isElementNode() && toElement(node)->isFormControlElement())
+ static_cast<HTMLFormControlElement*>(node)->ancestorDisabledStateWasChanged();
}
}
Modified: trunk/Source/WebCore/svg/SVGSVGElement.cpp (118887 => 118888)
--- trunk/Source/WebCore/svg/SVGSVGElement.cpp 2012-05-30 03:51:23 UTC (rev 118887)
+++ trunk/Source/WebCore/svg/SVGSVGElement.cpp 2012-05-30 04:03:07 UTC (rev 118888)
@@ -754,7 +754,7 @@
// Fall back to traversing our subtree. Duplicate ids are allowed, the first found will
// be returned.
- for (Node* node = traverseNextNode(this); node; node = node->traverseNextNode(this)) {
+ for (Node* node = firstChild(); node; node = node->traverseNextNode(this)) {
if (!node->isElementNode())
continue;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
