Title: [118933] trunk
- Revision
- 118933
- Author
- [email protected]
- Date
- 2012-05-30 10:17:15 -0700 (Wed, 30 May 2012)
Log Message
[EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
https://bugs.webkit.org/show_bug.cgi?id=87848
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-05-30
Reviewed by Csaba Osztrogonác.
Tools:
The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
(browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::extraViews):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):
LayoutTests:
* platform/efl/Skipped: Unskipped http/tests/navigation/new-window-redirect-history.html.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (118932 => 118933)
--- trunk/LayoutTests/ChangeLog 2012-05-30 17:02:49 UTC (rev 118932)
+++ trunk/LayoutTests/ChangeLog 2012-05-30 17:17:15 UTC (rev 118933)
@@ -1,3 +1,12 @@
+2012-05-30 Mikhail Pozdnyakov <[email protected]>
+
+ [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
+ https://bugs.webkit.org/show_bug.cgi?id=87848
+
+ Reviewed by Csaba Osztrogonác.
+
+ * platform/efl/Skipped: Unskipped http/tests/navigation/new-window-redirect-history.html.
+
2012-05-30 Sergio Villar Senin <[email protected]>
Unreviewed, removed some tests from the test_expectations file as
Modified: trunk/LayoutTests/platform/efl/Skipped (118932 => 118933)
--- trunk/LayoutTests/platform/efl/Skipped 2012-05-30 17:02:49 UTC (rev 118932)
+++ trunk/LayoutTests/platform/efl/Skipped 2012-05-30 17:17:15 UTC (rev 118933)
@@ -1118,7 +1118,6 @@
http/tests/misc/iframe-invalid-source-crash.html
http/tests/misc/submit-post-keygen.html
http/tests/navigation/forward-and-cancel.html
-http/tests/navigation/new-window-redirect-history.html
http/tests/navigation/no-referrer-reset.html
http/tests/navigation/no-referrer-target-blank.html
http/tests/navigation/ping-cross-origin-from-https.html
Modified: trunk/Tools/ChangeLog (118932 => 118933)
--- trunk/Tools/ChangeLog 2012-05-30 17:02:49 UTC (rev 118932)
+++ trunk/Tools/ChangeLog 2012-05-30 17:17:15 UTC (rev 118933)
@@ -1,5 +1,21 @@
2012-05-30 Mikhail Pozdnyakov <[email protected]>
+ [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
+ https://bugs.webkit.org/show_bug.cgi?id=87848
+
+ Reviewed by Csaba Osztrogonác.
+
+ The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
+ and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
+ (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
+
+ * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+ (DumpRenderTreeChrome::extraViews):
+ * DumpRenderTree/efl/DumpRenderTreeChrome.h:
+ (DumpRenderTreeChrome):
+
+2012-05-30 Mikhail Pozdnyakov <[email protected]>
+
[EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
https://bugs.webkit.org/show_bug.cgi?id=87833
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp (118932 => 118933)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-30 17:02:49 UTC (rev 118932)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp 2012-05-30 17:17:15 UTC (rev 118933)
@@ -174,7 +174,7 @@
return true;
}
-Vector<Evas_Object*> DumpRenderTreeChrome::extraViews() const
+const Vector<Evas_Object*>& DumpRenderTreeChrome::extraViews() const
{
return m_extraViews;
}
Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h (118932 => 118933)
--- trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h 2012-05-30 17:02:49 UTC (rev 118932)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTreeChrome.h 2012-05-30 17:17:15 UTC (rev 118933)
@@ -48,7 +48,7 @@
Evas_Object* createNewWindow();
void removeWindow(Evas_Object*);
- Vector<Evas_Object*> extraViews() const;
+ const Vector<Evas_Object*>& extraViews() const;
void clearExtraViews();
Evas_Object* mainFrame() const;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
