Title: [119063] trunk/Source
- Revision
- 119063
- Author
- [email protected]
- Date
- 2012-05-30 23:46:16 -0700 (Wed, 30 May 2012)
Log Message
[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
https://bugs.webkit.org/show_bug.cgi?id=87756
Patch by Sudarsana Nagineni <[email protected]> on 2012-05-30
Reviewed by Carlos Garcia Campos.
Source/WebKit/gtk:
Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.
* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag):
Source/WebKit2:
Fixed memory leaks in drag and drop by using adoptRef instead
of just getting new references.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseStartDrag):
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (119062 => 119063)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-05-31 06:46:16 UTC (rev 119063)
@@ -1,3 +1,16 @@
+2012-05-30 Sudarsana Nagineni <[email protected]>
+
+ [GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
+ https://bugs.webkit.org/show_bug.cgi?id=87756
+
+ Reviewed by Carlos Garcia Campos.
+
+ Fixed a memory leak in drag and drop by using adoptRef instead
+ of just getting a new reference of targetList.
+
+ * WebCoreSupport/DragClientGtk.cpp:
+ (WebKit::DragClient::startDrag):
+
2012-05-25 Jesus Sanchez-Palencia <[email protected]>
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp (119062 => 119063)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DragClientGtk.cpp 2012-05-31 06:46:16 UTC (rev 119063)
@@ -79,7 +79,7 @@
WebKitWebView* webView = webkit_web_frame_get_web_view(kit(frame));
RefPtr<DataObjectGtk> dataObject = clipboardGtk->dataObject();
- GRefPtr<GtkTargetList> targetList(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
+ GRefPtr<GtkTargetList> targetList = adoptGRef(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
GOwnPtr<GdkEvent> currentEvent(gtk_get_current_event());
GdkDragContext* context = gtk_drag_begin(GTK_WIDGET(m_webView), targetList.get(), dragOperationToGdkDragActions(clipboard->sourceOperation()), 1, currentEvent.get());
Modified: trunk/Source/WebKit2/ChangeLog (119062 => 119063)
--- trunk/Source/WebKit2/ChangeLog 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit2/ChangeLog 2012-05-31 06:46:16 UTC (rev 119063)
@@ -1,3 +1,16 @@
+2012-05-30 Sudarsana Nagineni <[email protected]>
+
+ [GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
+ https://bugs.webkit.org/show_bug.cgi?id=87756
+
+ Reviewed by Carlos Garcia Campos.
+
+ Fixed memory leaks in drag and drop by using adoptRef instead
+ of just getting new references.
+
+ * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+ (webkitWebViewBaseStartDrag):
+
2012-05-30 Luiz Agostini <[email protected]>
[Qt] handled touchmove events should not cancel tap gesture recognition
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp (119062 => 119063)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2012-05-31 06:36:42 UTC (rev 119062)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp 2012-05-31 06:46:16 UTC (rev 119063)
@@ -675,8 +675,8 @@
{
WebKitWebViewBasePrivate* priv = webViewBase->priv;
- RefPtr<DataObjectGtk> dataObject(dragData.platformData());
- GRefPtr<GtkTargetList> targetList(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
+ RefPtr<DataObjectGtk> dataObject = adoptRef(dragData.platformData());
+ GRefPtr<GtkTargetList> targetList = adoptGRef(PasteboardHelper::defaultPasteboardHelper()->targetListForDataObject(dataObject.get()));
GOwnPtr<GdkEvent> currentEvent(gtk_get_current_event());
GdkDragContext* context = gtk_drag_begin(GTK_WIDGET(webViewBase),
targetList.get(),
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
