Title: [119070] trunk/Source/WebCore
Revision
119070
Author
[email protected]
Date
2012-05-31 01:00:35 -0700 (Thu, 31 May 2012)

Log Message

[V8] Pass Isolate to v8String() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87825

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installFastSet):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::getParameterCallback):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (119069 => 119070)


--- trunk/Source/WebCore/ChangeLog	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/ChangeLog	2012-05-31 08:00:35 UTC (rev 119070)
@@ -1,3 +1,61 @@
+2012-05-31  Kentaro Hara  <[email protected]>
+
+        [V8] Pass Isolate to v8String() in custom bindings
+        https://bugs.webkit.org/show_bug.cgi?id=87825
+
+        Reviewed by Adam Barth.
+
+        The objective is to pass Isolate around in V8 bindings.
+        This patch passes Isolate to v8String() in custom bindings.
+
+        No tests. No change in behavior.
+
+        * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
+        (WebCore::installFastSet):
+        * bindings/v8/custom/V8ArrayBufferViewCustom.h:
+        (WebCore):
+        (WebCore::setWebGLArrayHelper):
+        * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
+        (WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
+        (WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
+        * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
+        (WebCore::toV8Object):
+        * bindings/v8/custom/V8ClipboardCustom.cpp:
+        (WebCore::V8Clipboard::typesAccessorGetter):
+        * bindings/v8/custom/V8DOMStringMapCustom.cpp:
+        (WebCore::V8DOMStringMap::namedPropertyGetter):
+        (WebCore::V8DOMStringMap::namedPropertyEnumerator):
+        * bindings/v8/custom/V8FileReaderCustom.cpp:
+        (WebCore::V8FileReader::resultAccessorGetter):
+        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
+        (WebCore::V8HTMLCanvasElement::toDataURLCallback):
+        * bindings/v8/custom/V8HTMLElementCustom.cpp:
+        (WebCore::toV8Object):
+        * bindings/v8/custom/V8HTMLInputElementCustom.cpp:
+        (WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
+        * bindings/v8/custom/V8IDBAnyCustom.cpp:
+        (WebCore::toV8):
+        * bindings/v8/custom/V8IDBKeyCustom.cpp:
+        (WebCore::toV8):
+        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
+        (WebCore::V8InjectedScriptHost::databaseIdCallback):
+        (WebCore::V8InjectedScriptHost::storageIdCallback):
+        * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
+        (WebCore::V8InspectorFrontendHost::platformCallback):
+        * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
+        (WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
+        * bindings/v8/custom/V8LocationCustom.cpp:
+        (WebCore::V8Location::toStringCallback):
+        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+        (WebCore::V8SQLResultSetRowList::itemCallback):
+        * bindings/v8/custom/V8StorageCustom.cpp:
+        (WebCore::V8Storage::namedPropertyEnumerator):
+        (WebCore::storageGetter):
+        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
+        (WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
+        * bindings/v8/custom/V8XSLTProcessorCustom.cpp:
+        (WebCore::V8XSLTProcessor::getParameterCallback):
+
 2012-05-31  Hayato Ito  <[email protected]>
 
         ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.

Modified: trunk/Source/WebCore/bindings/v8/V8Collection.h (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/V8Collection.h	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/V8Collection.h	2012-05-31 08:00:35 UTC (rev 119070)
@@ -135,7 +135,7 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     Collection* collection = toNativeCollection<Collection>(info.Holder());
     String result = collection->item(index);
-    return v8StringOrNull(result);
+    return v8StringOrNull(result, info.GetIsolate());
 }
 
 
@@ -146,7 +146,7 @@
     ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
     Collection* collection = toNativeCollection<Collection>(info.Holder());
     String result = collection->item(index);
-    return v8String(result);
+    return v8String(result, info.GetIsolate());
 }
 
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -54,7 +54,7 @@
     return value;
 }
 
-bool copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t length, uint32_t offset)
+bool copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t length, uint32_t offset, v8::Isolate* isolate)
 {
     v8::Handle<v8::Value> prototype_value = destArray->GetPrototype();
     if (prototype_value.IsEmpty() || !prototype_value->IsObject())

Modified: trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h	2012-05-31 08:00:35 UTC (rev 119070)
@@ -42,7 +42,7 @@
 
 // Copy the elements from the source array to the typed destination array.
 // Returns true if it succeeded, otherwise returns false.
-bool copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t length, uint32_t offset);
+bool copyElements(v8::Handle<v8::Object> destArray, v8::Handle<v8::Object> srcArray, uint32_t length, uint32_t offset, v8::Isolate*);
 
 
 // Template function used by the ArrayBufferView*Constructor callbacks.
@@ -165,7 +165,7 @@
     args.Holder()->SetIndexedPropertiesToExternalArrayData(array.get()->baseAddress(), arrayType, array.get()->length());
 
     if (!srcArray.IsEmpty()) {
-        bool copied = copyElements(args.Holder(), srcArray, len, 0);
+        bool copied = copyElements(args.Holder(), srcArray, len, 0, args.GetIsolate());
         if (!copied) {
             for (unsigned i = 0; i < len; i++)
                 array->set(i, srcArray->Get(i)->NumberValue());
@@ -210,7 +210,7 @@
             // Out of range offset or overflow
             return V8Proxy::setDOMException(INDEX_SIZE_ERR, args.GetIsolate());
         }
-        bool copied = copyElements(args.Holder(), array, length, offset);
+        bool copied = copyElements(args.Holder(), array, length, offset, args.GetIsolate());
         if (!copied) {
             for (uint32_t i = 0; i < length; i++)
                 impl->set(offset + i, array->Get(i)->NumberValue());

Modified: trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -174,7 +174,7 @@
     for (unsigned i = 0; i < propertyNamesLength; ++i) {
         String key = propertyNames.at(i);
         ASSERT(!key.isNull());
-        properties->Set(v8::Integer::New(i), v8String(key));
+        properties->Set(v8::Integer::New(i), v8String(key, info.GetIsolate()));
     }
 
     return properties;
@@ -212,14 +212,14 @@
             return v8::Number::New(static_cast<CSSPrimitiveValue*>(
                 cssValue.get())->getFloatValue(CSSPrimitiveValue::CSS_PX));
         }
-        return v8StringOrNull(cssValue->cssText());
+        return v8StringOrNull(cssValue->cssText(), info.GetIsolate());
     }
 
     String result = imp->getPropertyValueInternal(static_cast<CSSPropertyID>(propInfo->propID));
     if (result.isNull())
         result = "";  // convert null to empty string.
 
-    return v8String(result);
+    return v8String(result, info.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8CSSStyleDeclaration::namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -57,7 +57,7 @@
     if (style->canvasPattern())
         return toV8(style->canvasPattern(), isolate);
 
-    return v8String(style->color());
+    return v8String(style->color(), isolate);
 }
 
 static PassRefPtr<CanvasStyle> toCanvasStyle(v8::Handle<v8::Value> value)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -57,7 +57,7 @@
     HashSet<String>::const_iterator end = types.end();
     int index = 0;
     for (HashSet<String>::const_iterator it = types.begin(); it != end; ++it, ++index)
-        result->Set(v8::Integer::New(index), v8String(*it));
+        result->Set(v8::Integer::New(index), v8String(*it, info.GetIsolate()));
 
     return result;
 }

Modified: trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -52,7 +52,7 @@
     String value = V8DOMStringMap::toNative(info.Holder())->item(toWebCoreString(name));
     if (value.isNull())
         return v8::Handle<v8::Value>();
-    return v8StringOrUndefined(value);
+    return v8StringOrUndefined(value, info.GetIsolate());
 }
 
 v8::Handle<v8::Array> V8DOMStringMap::namedPropertyEnumerator(const v8::AccessorInfo& info)
@@ -62,7 +62,7 @@
     V8DOMStringMap::toNative(info.Holder())->getNames(names);
     v8::Handle<v8::Array> properties = v8::Array::New(names.size());
     for (size_t i = 0; i < names.size(); ++i)
-        properties->Set(v8::Integer::New(i), v8String(names[i]));
+        properties->Set(v8::Integer::New(i), v8String(names[i], info.GetIsolate()));
     return properties;
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8FileReaderCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8FileReaderCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8FileReaderCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -47,7 +47,7 @@
     FileReader* imp = V8FileReader::toNative(holder);
     if (imp->readType() == FileReaderLoader::ReadAsArrayBuffer)
         return toV8(imp->arrayBufferResult(), info.GetIsolate());
-    return v8StringOrNull(imp->stringResult());
+    return v8StringOrNull(imp->stringResult(), info.GetIsolate());
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -111,7 +111,7 @@
 
     String result = canvas->toDataURL(type, qualityPtr, ec);
     V8Proxy::setDOMException(ec, args.GetIsolate());
-    return v8StringOrUndefined(result);
+    return v8StringOrUndefined(result, args.GetIsolate());
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -56,7 +56,7 @@
     if (itemValue->isNode())
         return toV8(itemValue->getNode(), isolate);
 
-    return v8String(itemValue->getString());
+    return v8String(itemValue->getString(), isolate);
 }
 
 v8::Handle<v8::Value> V8HTMLElement::itemValueAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8HTMLInputElementCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8HTMLInputElementCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8HTMLInputElementCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -100,7 +100,7 @@
     if (!imp->canHaveSelection())
         return V8Proxy::throwTypeError("Accessing selectionDirection on an input element that cannot have a selection.", info.GetIsolate());
 
-    return v8String(imp->selectionDirection());
+    return v8String(imp->selectionDirection(), info.GetIsolate());
 }
 
 void V8HTMLInputElement::selectionDirectionAccessorSetter(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::AccessorInfo& info)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IDBAnyCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -76,7 +76,7 @@
     case IDBAny::SerializedScriptValueType:
         return impl->serializedScriptValue()->deserialize(0, isolate);
     case IDBAny::StringType:
-        return v8String(impl->string());
+        return v8String(impl->string(), isolate);
     }
 
     ASSERT_NOT_REACHED();

Modified: trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8IDBKeyCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -51,7 +51,7 @@
     case IDBKey::NumberType:
         return v8::Number::New(key->number());
     case IDBKey::StringType:
-        return v8String(key->string());
+        return v8String(key->string(), isolate);
     case IDBKey::DateType:
         return v8::Date::New(key->date());
     case IDBKey::ArrayType:

Modified: trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -274,7 +274,7 @@
     InjectedScriptHost* host = V8InjectedScriptHost::toNative(args.Holder());
     Database* database = V8Database::toNative(v8::Handle<v8::Object>::Cast(args[0]));
     if (database)
-        return v8StringOrUndefined(host->databaseIdImpl(database));
+        return v8StringOrUndefined(host->databaseIdImpl(database), args.GetIsolate());
 #endif
     return v8::Undefined();
 }
@@ -287,7 +287,7 @@
     InjectedScriptHost* host = V8InjectedScriptHost::toNative(args.Holder());
     Storage* storage = V8Storage::toNative(v8::Handle<v8::Object>::Cast(args[0]));
     if (storage)
-        return v8StringOrUndefined(host->storageIdImpl(storage));
+        return v8StringOrUndefined(host->storageIdImpl(storage), args.GetIsolate());
     return v8::Undefined();
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -44,22 +44,22 @@
 
 namespace WebCore {
 
-v8::Handle<v8::Value> V8InspectorFrontendHost::platformCallback(const v8::Arguments&)
+v8::Handle<v8::Value> V8InspectorFrontendHost::platformCallback(const v8::Arguments& args)
 {
 #if defined(OS_MACOSX)
-    return v8String("mac");
+    return v8String("mac", args.GetIsolate());
 #elif defined(OS_LINUX)
-    return v8String("linux");
+    return v8String("linux", args.GetIsolate());
 #elif defined(OS_FREEBSD)
-    return v8String("freebsd");
+    return v8String("freebsd", args.GetIsolate());
 #elif defined(OS_OPENBSD)
-    return v8String("openbsd");
+    return v8String("openbsd", args.GetIsolate());
 #elif defined(OS_SOLARIS)
-    return v8String("solaris");
+    return v8String("solaris", args.GetIsolate());
 #elif defined(OS_WIN)
-    return v8String("windows");
+    return v8String("windows", args.GetIsolate());
 #else
-    return v8String("unknown");
+    return v8String("unknown", args.GetIsolate());
 #endif
 }
 

Modified: trunk/Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -71,7 +71,7 @@
 v8::Handle<v8::Value> V8JavaScriptCallFrame::typeAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)
 {
     INC_STATS("V8JavaScriptCallFrame.typeAccessorGetter()");
-    return v8String("function");
+    return v8String("function", info.GetIsolate());
 }
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -255,7 +255,7 @@
     if (!V8BindingSecurity::canAccessFrame(V8BindingState::Only(), imp->frame(), true))
         return v8::Undefined();
     String result = imp->href();
-    return v8String(result);
+    return v8String(result, args.GetIsolate());
 }
 
 bool V8Location::indexedSecurityCheck(v8::Local<v8::Object> host, uint32_t index, v8::AccessType type, v8::Local<v8::Value>)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -64,7 +64,7 @@
         v8::Handle<v8::Value> value;
         switch(sqlValue.type()) {
             case SQLValue::StringValue:
-                value = v8String(sqlValue.string());
+                value = v8String(sqlValue.string(), args.GetIsolate());
                 break;
             case SQLValue::NullValue:
                 value = v8::Null(args.GetIsolate());
@@ -76,7 +76,7 @@
                 ASSERT_NOT_REACHED();
         }
 
-        item->Set(v8String(rowList->columnNames()[i]), value, static_cast<v8::PropertyAttribute>(v8::DontDelete|v8::ReadOnly));
+        item->Set(v8String(rowList->columnNames()[i], args.GetIsolate()), value, static_cast<v8::PropertyAttribute>(v8::DontDelete | v8::ReadOnly));
     }
 
     return item;

Modified: trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8StorageCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -47,7 +47,7 @@
         String key = storage->key(i);
         ASSERT(!key.isNull());
         String val = storage->getItem(key);
-        properties->Set(v8::Integer::New(i), v8String(key));
+        properties->Set(v8::Integer::New(i), v8String(key, info.GetIsolate()));
     }
 
     return properties;
@@ -59,7 +59,7 @@
     String name = toWebCoreString(v8Name);
 
     if (name != "length" && storage->contains(name))
-        return v8String(storage->getItem(name));
+        return v8String(storage->getItem(name), info.GetIsolate());
 
     return v8::Handle<v8::Value>();
 }

Modified: trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -57,7 +57,7 @@
     const String& text = xmlHttpRequest->responseText(ec);
     if (ec)
         return throwError(ec, info.GetIsolate());
-    return v8String(text);
+    return v8String(text, info.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8XMLHttpRequest::responseAccessorGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info)

Modified: trunk/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp (119069 => 119070)


--- trunk/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp	2012-05-31 07:55:29 UTC (rev 119069)
+++ trunk/Source/WebCore/bindings/v8/custom/V8XSLTProcessorCustom.cpp	2012-05-31 08:00:35 UTC (rev 119070)
@@ -130,7 +130,7 @@
     if (result.isNull())
         return v8::Undefined();
 
-    return v8String(result);
+    return v8String(result, args.GetIsolate());
 }
 
 v8::Handle<v8::Value> V8XSLTProcessor::removeParameterCallback(const v8::Arguments& args)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to