Title: [119085] trunk/Source/WebKit/chromium
- Revision
- 119085
- Author
- [email protected]
- Date
- 2012-05-31 04:28:40 -0700 (Thu, 31 May 2012)
Log Message
Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871
Reviewed by Yury Semikhatsky.
When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (119084 => 119085)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 11:22:29 UTC (rev 119084)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-05-31 11:28:40 UTC (rev 119085)
@@ -1,3 +1,18 @@
+2012-05-31 Alexander Pavlov <[email protected]>
+
+ Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
+ https://bugs.webkit.org/show_bug.cgi?id=87871
+
+ Reviewed by Yury Semikhatsky.
+
+ When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
+ these events as NOT handled by the WebKit, so that the browser can handle them appropriately
+ (on MacOS, switching between the application windows is done through the default key event handler, so if you run
+ event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).
+
+ * src/WebViewImpl.cpp:
+ (WebKit::WebViewImpl::handleInputEvent):
+
2012-05-31 Peter Beverloo <[email protected]>
Unreviewed. Rolled DEPS.
Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (119084 => 119085)
--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-05-31 11:22:29 UTC (rev 119084)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp 2012-05-31 11:28:40 UTC (rev 119085)
@@ -1678,8 +1678,9 @@
if (m_doingDragAndDrop)
return true;
+ // Report the event to be NOT processed by WebKit, so that the browser can handle it appropriately.
if (m_ignoreInputEvents)
- return true;
+ return false;
m_currentInputEvent = &inputEvent;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
