Title: [119207] trunk/Source/WebCore
Revision
119207
Author
[email protected]
Date
2012-06-01 03:39:05 -0700 (Fri, 01 Jun 2012)

Log Message

ASSERT(m_fontSelector->document()) is bogus and should be removed
https://bugs.webkit.org/show_bug.cgi?id=88053

Reviewed by Abhishek Arya.

This ASSERT was introduced in http://trac.webkit.org/changeset/97402
together with a branch that handled the case of the ASSERT firing.
This ASSERT fires when running tests on Android (which runs with
ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
it.

* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::getFontData):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (119206 => 119207)


--- trunk/Source/WebCore/ChangeLog	2012-06-01 10:37:24 UTC (rev 119206)
+++ trunk/Source/WebCore/ChangeLog	2012-06-01 10:39:05 UTC (rev 119207)
@@ -1,3 +1,19 @@
+2012-06-01  Adam Barth  <[email protected]>
+
+        ASSERT(m_fontSelector->document()) is bogus and should be removed
+        https://bugs.webkit.org/show_bug.cgi?id=88053
+
+        Reviewed by Abhishek Arya.
+
+        This ASSERT was introduced in http://trac.webkit.org/changeset/97402
+        together with a branch that handled the case of the ASSERT firing.
+        This ASSERT fires when running tests on Android (which runs with
+        ASSERTs enabled). The ASSERT appears to be bogus, so this patch removes
+        it.
+
+        * css/CSSSegmentedFontFace.cpp:
+        (WebCore::CSSSegmentedFontFace::getFontData):
+
 2012-06-01  Yoshifumi Inoue  <[email protected]>
 
         [Platform][Decimal] UInt128::operator/= calls makeUInt128 with wrong argument order

Modified: trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp (119206 => 119207)


--- trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp	2012-06-01 10:37:24 UTC (rev 119206)
+++ trunk/Source/WebCore/css/CSSSegmentedFontFace.cpp	2012-06-01 10:39:05 UTC (rev 119207)
@@ -125,7 +125,6 @@
         }
     }
     if (newFontData->numRanges()) {
-        ASSERT(m_fontSelector->document());
         if (Document* document = m_fontSelector->document()) {
             fontData = newFontData.get();
             document->registerCustomFont(newFontData.release());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to