Title: [119212] trunk/Source/WebCore
Revision
119212
Author
[email protected]
Date
2012-06-01 04:26:49 -0700 (Fri, 01 Jun 2012)

Log Message

Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
https://bugs.webkit.org/show_bug.cgi?id=88074

Reviewed by Yury Semikhatsky.

The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
"white-space: nowrap" to avoid wrapping individual cells.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
* inspector/front-end/elementsPanel.css:
* inspector/front-end/inspector.css:
(.nowrap):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (119211 => 119212)


--- trunk/Source/WebCore/ChangeLog	2012-06-01 11:18:32 UTC (rev 119211)
+++ trunk/Source/WebCore/ChangeLog	2012-06-01 11:26:49 UTC (rev 119212)
@@ -1,3 +1,19 @@
+2012-06-01  Alexander Pavlov  <[email protected]>
+
+        Web Inspector: [REGRESSION] Bad layout of "Override device metrics" controls in the Settings dialog
+        https://bugs.webkit.org/show_bug.cgi?id=88074
+
+        Reviewed by Yury Semikhatsky.
+
+        The "Override device metrics" controls are placed in a table, which gets too narrow. Give it a
+        "white-space: nowrap" to avoid wrapping individual cells.
+
+        * inspector/front-end/SettingsScreen.js:
+        (WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
+        * inspector/front-end/elementsPanel.css:
+        * inspector/front-end/inspector.css:
+        (.nowrap):
+
 2012-06-01  Sudarsana Nagineni  <[email protected]>
 
         [EFL] Implement PlatformStrategies

Modified: trunk/Source/WebCore/inspector/front-end/SettingsScreen.js (119211 => 119212)


--- trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-06-01 11:18:32 UTC (rev 119211)
+++ trunk/Source/WebCore/inspector/front-end/SettingsScreen.js	2012-06-01 11:26:49 UTC (rev 119212)
@@ -603,7 +603,7 @@
             this._applyDeviceMetricsUserInput();
         }
 
-        var tableElement = fieldsetElement.createChild("table");
+        var tableElement = fieldsetElement.createChild("table", "nowrap");
 
         var rowElement = tableElement.createChild("tr");
         var cellElement = rowElement.createChild("td");

Modified: trunk/Source/WebCore/inspector/front-end/elementsPanel.css (119211 => 119212)


--- trunk/Source/WebCore/inspector/front-end/elementsPanel.css	2012-06-01 11:18:32 UTC (rev 119211)
+++ trunk/Source/WebCore/inspector/front-end/elementsPanel.css	2012-06-01 11:26:49 UTC (rev 119212)
@@ -27,10 +27,6 @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#elements-content.nowrap {
-    white-space: nowrap;
-}
-
 #elements-content {
     padding-left: 0;
 }

Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (119211 => 119212)


--- trunk/Source/WebCore/inspector/front-end/inspector.css	2012-06-01 11:18:32 UTC (rev 119211)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css	2012-06-01 11:26:49 UTC (rev 119212)
@@ -43,6 +43,10 @@
     display: none;
 }
 
+.nowrap {
+    white-space: nowrap;
+}
+
 #toolbar {
     position: absolute;
     top: 0;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to