Title: [119290] trunk/Source/WebKit/blackberry
- Revision
- 119290
- Author
- [email protected]
- Date
- 2012-06-01 15:34:30 -0700 (Fri, 01 Jun 2012)
Log Message
[BlackBerry] Fix the return value checking in SelectPopupClient
https://bugs.webkit.org/show_bug.cgi?id=88130
Patch by Crystal Zhang <[email protected]> on 2012-06-01
Reviewed by Rob Buis.
In SelectPopupClient, return '1' means selected, '0' means not selected,
the ASCII value of '0' is 48, not 32, use '0' to be more readable.
* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValueAndClosePopup):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (119289 => 119290)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-01 22:32:28 UTC (rev 119289)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-01 22:34:30 UTC (rev 119290)
@@ -1,3 +1,16 @@
+2012-06-01 Crystal Zhang <[email protected]>
+
+ [BlackBerry] Fix the return value checking in SelectPopupClient
+ https://bugs.webkit.org/show_bug.cgi?id=88130
+
+ Reviewed by Rob Buis.
+
+ In SelectPopupClient, return '1' means selected, '0' means not selected,
+ the ASCII value of '0' is 48, not 32, use '0' to be more readable.
+
+ * WebCoreSupport/SelectPopupClient.cpp:
+ (WebCore::SelectPopupClient::setValueAndClosePopup):
+
2012-06-01 Jonathan Dong <[email protected]>
[BlackBerry] Add end editing handling into AutofillManager
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp (119289 => 119290)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2012-06-01 22:32:28 UTC (rev 119289)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp 2012-06-01 22:34:30 UTC (rev 119290)
@@ -142,7 +142,7 @@
if (m_size > 0) {
bool selecteds[m_size];
for (unsigned i = 0; i < m_size; i++)
- selecteds[i] = stringValue[i] - 32;
+ selecteds[i] = stringValue[i] - '0';
const WTF::Vector<HTMLElement*>& items = m_element->listItems();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
