Title: [119469] trunk
- Revision
- 119469
- Author
- [email protected]
- Date
- 2012-06-05 01:56:24 -0700 (Tue, 05 Jun 2012)
Log Message
Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
https://bugs.webkit.org/show_bug.cgi?id=88257
Reviewed by Pavel Feldman.
Source/WebCore:
Canonical names for properties should be used when checking if they are inherited (since only canonical names
are put into the usedProperties set).
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
LayoutTests:
* inspector/elements/elements-panel-styles-expected.txt:
* inspector/elements/elements-panel-styles.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (119468 => 119469)
--- trunk/LayoutTests/ChangeLog 2012-06-05 08:27:06 UTC (rev 119468)
+++ trunk/LayoutTests/ChangeLog 2012-06-05 08:56:24 UTC (rev 119469)
@@ -1,3 +1,13 @@
+2012-06-05 Alexander Pavlov <[email protected]>
+
+ Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
+ https://bugs.webkit.org/show_bug.cgi?id=88257
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/elements/elements-panel-styles-expected.txt:
+ * inspector/elements/elements-panel-styles.html:
+
2012-06-05 Kenichi Ishibashi <[email protected]>
[Chromium] Implement font shaping with font-feature-settings on Mac
Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt (119468 => 119469)
--- trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt 2012-06-05 08:27:06 UTC (rev 119468)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles-expected.txt 2012-06-05 08:56:24 UTC (rev 119469)
@@ -1,6 +1,8 @@
Tests that elements panel shows proper styles in the sidebar panel.
[expanded]
+-webkit-font-smoothing: subpixel-antialiased;
+ element.style - subpixel-antialiased
border-bottom-left-radius: 5px;
.foo - 5px elements-panel-styles.css:14
border-bottom-right-radius: 5px;
@@ -37,6 +39,7 @@
[expanded]
element.style { ()
display: none;
+-webkit-font-smoothing: subpixel-antialiased;
======== Matched CSS Rules ========
[expanded]
Modified: trunk/LayoutTests/inspector/elements/elements-panel-styles.html (119468 => 119469)
--- trunk/LayoutTests/inspector/elements/elements-panel-styles.html 2012-06-05 08:27:06 UTC (rev 119468)
+++ trunk/LayoutTests/inspector/elements/elements-panel-styles.html 2012-06-05 08:56:24 UTC (rev 119469)
@@ -26,7 +26,7 @@
</p>
<div id="container">
- <div id="foo" class="foo" style="display:none" align="left">Foo</div>
+ <div id="foo" class="foo" style="display:none; -webkit-font-smoothing: subpixel-antialiased;" align="left">Foo</div>
</div>
</body>
Modified: trunk/Source/WebCore/ChangeLog (119468 => 119469)
--- trunk/Source/WebCore/ChangeLog 2012-06-05 08:27:06 UTC (rev 119468)
+++ trunk/Source/WebCore/ChangeLog 2012-06-05 08:56:24 UTC (rev 119469)
@@ -1,3 +1,16 @@
+2012-06-05 Alexander Pavlov <[email protected]>
+
+ Web Inspector: "-webkit"-prefixed properties are considered inherited in the Computed Style pane
+ https://bugs.webkit.org/show_bug.cgi?id=88257
+
+ Reviewed by Pavel Feldman.
+
+ Canonical names for properties should be used when checking if they are inherited (since only canonical names
+ are put into the usedProperties set).
+
+ * inspector/front-end/StylesSidebarPane.js:
+ (WebInspector.ComputedStylePropertiesSection.prototype._isPropertyInherited):
+
2012-06-05 Kenichi Ishibashi <[email protected]>
[Chromium] Implement font shaping with font-feature-settings on Mac
Modified: trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js (119468 => 119469)
--- trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-06-05 08:27:06 UTC (rev 119468)
+++ trunk/Source/WebCore/inspector/front-end/StylesSidebarPane.js 2012-06-05 08:56:24 UTC (rev 119469)
@@ -1397,7 +1397,8 @@
_isPropertyInherited: function(propertyName)
{
- return !(propertyName in this._usedProperties) && !(propertyName in this._alwaysShowComputedProperties);
+ var canonicalName = WebInspector.StylesSidebarPane.canonicalPropertyName(propertyName);
+ return !(canonicalName in this._usedProperties) && !(canonicalName in this._alwaysShowComputedProperties);
},
update: function()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
