Title: [119479] trunk
- Revision
- 119479
- Author
- [email protected]
- Date
- 2012-06-05 03:57:00 -0700 (Tue, 05 Jun 2012)
Log Message
Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
https://bugs.webkit.org/show_bug.cgi?id=85174
Reviewed by Kentaro Hara.
Source/WebCore:
This fixes a crash problem which could happen when the constructor is
given an array which contains String-type item(s).
There're still some Text mismatches between v8 results and
JSC results, most of them are v8 not throwing exception
when it is given an object whose toString() method throws
exception. (The issue will be addresse in a separate patch.)
Test: fast/files/blob-constructor.html
* bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCallback):
LayoutTests:
Changing blob-constructor.html label from CRASH to TEXT.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (119478 => 119479)
--- trunk/LayoutTests/ChangeLog 2012-06-05 10:39:59 UTC (rev 119478)
+++ trunk/LayoutTests/ChangeLog 2012-06-05 10:57:00 UTC (rev 119479)
@@ -1,3 +1,14 @@
+2012-06-04 Kinuko Yasuda <[email protected]>
+
+ Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=85174
+
+ Reviewed by Kentaro Hara.
+
+ Changing blob-constructor.html label from CRASH to TEXT.
+
+ * platform/chromium/TestExpectations:
+
2012-06-05 Kenichi Ishibashi <[email protected]>
[Chromium] Unreviewed test expectations update
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (119478 => 119479)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-05 10:39:59 UTC (rev 119478)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-05 10:57:00 UTC (rev 119479)
@@ -3612,7 +3612,7 @@
BUGWK85090 DEBUG SLOW : fast/js/dfg-uint8array.html = PASS
BUGWK85106 SLOW : tables/mozilla/other/slashlogo.html = PASS
-BUGWK85174 : fast/files/blob-constructor.html = CRASH
+BUGWK85174 : fast/files/blob-constructor.html = TEXT
BUGWK85174 : fast/dom/HTMLAnchorElement/anchor-download-unset.html = TIMEOUT
BUGWK85174 : fast/filesystem/file-writer-gc-blob.html = TIMEOUT
BUGWK85174 : fast/filesystem/workers/file-writer-gc-blob.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (119478 => 119479)
--- trunk/Source/WebCore/ChangeLog 2012-06-05 10:39:59 UTC (rev 119478)
+++ trunk/Source/WebCore/ChangeLog 2012-06-05 10:57:00 UTC (rev 119479)
@@ -1,3 +1,23 @@
+2012-06-04 Kinuko Yasuda <[email protected]>
+
+ Chromium tests: "Add support for the Blob constructor" [r115582] regressed blob layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=85174
+
+ Reviewed by Kentaro Hara.
+
+ This fixes a crash problem which could happen when the constructor is
+ given an array which contains String-type item(s).
+
+ There're still some Text mismatches between v8 results and
+ JSC results, most of them are v8 not throwing exception
+ when it is given an object whose toString() method throws
+ exception. (The issue will be addresse in a separate patch.)
+
+ Test: fast/files/blob-constructor.html
+
+ * bindings/v8/custom/V8BlobCustom.cpp:
+ (WebCore::V8Blob::constructorCallback):
+
2012-06-05 Kentaro Hara <[email protected]>
Remove unnecessary constructor of SelectorQueryCache
Modified: trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp (119478 => 119479)
--- trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2012-06-05 10:39:59 UTC (rev 119478)
+++ trunk/Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp 2012-06-05 10:57:00 UTC (rev 119479)
@@ -126,7 +126,7 @@
ASSERT(blob);
blobBuilder->append(blob);
} else {
- EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item->ToString()));
+ EXCEPTION_BLOCK(String, stringValue, toWebCoreString(item));
blobBuilder->append(stringValue, endings, ASSERT_NO_EXCEPTION);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
