Title: [119506] trunk/Source/WebCore
- Revision
- 119506
- Author
- [email protected]
- Date
- 2012-06-05 11:28:47 -0700 (Tue, 05 Jun 2012)
Log Message
REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
https://bugs.webkit.org/show_bug.cgi?id=88296
Reviewed by Dan Bernstein.
refresh() and initPlugins() should call into PluginStrategy even if
ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
plug-ins, so PluginStrategy should be consulted even if Netscape
plug-ins specifically are disabled.
Ports that support platform strategies but not Netscape plug-ins should
handle this inside their PluginStrategy rather than modifying generic
plug-in code.
* plugins/PluginData.cpp:
(WebCore::PluginData::refresh):
(WebCore::PluginData::initPlugins):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119505 => 119506)
--- trunk/Source/WebCore/ChangeLog 2012-06-05 18:23:27 UTC (rev 119505)
+++ trunk/Source/WebCore/ChangeLog 2012-06-05 18:28:47 UTC (rev 119506)
@@ -1,3 +1,23 @@
+2012-06-05 Andy Estes <[email protected]>
+
+ REGRESSION (r118197): PluginStrategy should be used even if ENABLE(NETSCAPE_PLUGIN_API) is false
+ https://bugs.webkit.org/show_bug.cgi?id=88296
+
+ Reviewed by Dan Bernstein.
+
+ refresh() and initPlugins() should call into PluginStrategy even if
+ ENABLE(NETSCAPE_PLUGIN_API) is false. Some ports support non-Netscape
+ plug-ins, so PluginStrategy should be consulted even if Netscape
+ plug-ins specifically are disabled.
+
+ Ports that support platform strategies but not Netscape plug-ins should
+ handle this inside their PluginStrategy rather than modifying generic
+ plug-in code.
+
+ * plugins/PluginData.cpp:
+ (WebCore::PluginData::refresh):
+ (WebCore::PluginData::initPlugins):
+
2012-06-05 Douglas Stockwell <[email protected]>
Crash when modifying fixed-position elements in a detached frame
Modified: trunk/Source/WebCore/plugins/PluginData.cpp (119505 => 119506)
--- trunk/Source/WebCore/plugins/PluginData.cpp 2012-06-05 18:23:27 UTC (rev 119505)
+++ trunk/Source/WebCore/plugins/PluginData.cpp 2012-06-05 18:28:47 UTC (rev 119506)
@@ -67,20 +67,14 @@
#if USE(PLATFORM_STRATEGIES)
void PluginData::refresh()
{
-#if ENABLE(NETSCAPE_PLUGIN_API)
platformStrategies()->pluginStrategy()->refreshPlugins();
-#endif
}
void PluginData::initPlugins(const Page* page)
{
-#if ENABLE(NETSCAPE_PLUGIN_API)
ASSERT(m_plugins.isEmpty());
platformStrategies()->pluginStrategy()->getPluginInfo(page, m_plugins);
-#else
- UNUSED_PARAM(page);
-#endif
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
