Title: [119581] trunk/Source/WebCore
- Revision
- 119581
- Author
- [email protected]
- Date
- 2012-06-06 03:41:54 -0700 (Wed, 06 Jun 2012)
Log Message
Web Inspector: help/settings screen does not overlay console in split screen mode
https://bugs.webkit.org/show_bug.cgi?id=88352
Patch by Eugene Klyuchnikov <[email protected]> on 2012-06-06
Reviewed by Pavel Feldman.
* inspector/front-end/HelpScreen.js:
(WebInspector.HelpScreen): Mark view as root.
(WebInspector.HelpScreen.prototype.showModal): Change view parent.
* inspector/front-end/helpScreen.css:
(.help-window-outer): Add panel and status bar indent.
(body.compact .help-window-outer): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119580 => 119581)
--- trunk/Source/WebCore/ChangeLog 2012-06-06 10:26:18 UTC (rev 119580)
+++ trunk/Source/WebCore/ChangeLog 2012-06-06 10:41:54 UTC (rev 119581)
@@ -1,3 +1,17 @@
+2012-06-06 Eugene Klyuchnikov <[email protected]>
+
+ Web Inspector: help/settings screen does not overlay console in split screen mode
+ https://bugs.webkit.org/show_bug.cgi?id=88352
+
+ Reviewed by Pavel Feldman.
+
+ * inspector/front-end/HelpScreen.js:
+ (WebInspector.HelpScreen): Mark view as root.
+ (WebInspector.HelpScreen.prototype.showModal): Change view parent.
+ * inspector/front-end/helpScreen.css:
+ (.help-window-outer): Add panel and status bar indent.
+ (body.compact .help-window-outer): Ditto.
+
2012-06-06 Yoshifumi Inoue <[email protected]>
[Form] Changes for InputNumber type
Modified: trunk/Source/WebCore/inspector/front-end/HelpScreen.js (119580 => 119581)
--- trunk/Source/WebCore/inspector/front-end/HelpScreen.js 2012-06-06 10:26:18 UTC (rev 119580)
+++ trunk/Source/WebCore/inspector/front-end/HelpScreen.js 2012-06-06 10:41:54 UTC (rev 119581)
@@ -36,6 +36,7 @@
WebInspector.HelpScreen = function(title)
{
WebInspector.View.call(this);
+ this.markAsRoot();
this.registerRequiredCSS("helpScreen.css");
this.element.className = "help-window-outer";
@@ -76,7 +77,7 @@
if (visibleHelpScreen)
visibleHelpScreen.hide();
WebInspector.HelpScreen._visibleScreen = this;
- this.show(WebInspector.inspectorView.element);
+ this.show(document.body);
this.focus();
},
Modified: trunk/Source/WebCore/inspector/front-end/helpScreen.css (119580 => 119581)
--- trunk/Source/WebCore/inspector/front-end/helpScreen.css 2012-06-06 10:26:18 UTC (rev 119580)
+++ trunk/Source/WebCore/inspector/front-end/helpScreen.css 2012-06-06 10:41:54 UTC (rev 119581)
@@ -1,17 +1,17 @@
.help-window-outer {
position: absolute;
- top: 12px;
+ top: 64px;
left: 5%;
width: 90%;
- bottom: 12px;
+ bottom: 32px;
z-index: 2000;
}
body.compact .help-window-outer {
- top: 0;
+ top: 34px;
left: 0;
width: 100%;
- bottom: 0;
+ bottom: 23px;
}
.help-window-main {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
