Title: [119681] trunk/Source/WebKit/blackberry
- Revision
- 119681
- Author
- [email protected]
- Date
- 2012-06-06 21:34:56 -0700 (Wed, 06 Jun 2012)
Log Message
[BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=88488
PR #162991
Reviewed by George Staikos.
Patch by Antonio Gomes <[email protected]>
When we use width:100%/pageScale as the math to calculate the width of the
FullScreen element, it goes too wide for horizontally scrollable webpages.
The reason is that 100% is relative to the content size here, and we want 100%
relative to the viewport size. However, since there is no such a thing in CSS,
we set an absolute file.
A known problem with this will be rotating the device when in fullscreen mode
that we can address when rotating is supported.
Internally reviewed by Jacky Jiang.
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (119680 => 119681)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-06-07 04:34:40 UTC (rev 119680)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-06-07 04:34:56 UTC (rev 119681)
@@ -1,3 +1,25 @@
+2012-06-06 Antonio Gomes <[email protected]>
+
+ [BlackBerry] browser video player fullscreen mode (portrait) - Controls are off screen so cannot exit fullscreen
+ https://bugs.webkit.org/show_bug.cgi?id=88488
+ PR #162991
+
+ Reviewed by George Staikos.
+
+ When we use width:100%/pageScale as the math to calculate the width of the
+ FullScreen element, it goes too wide for horizontally scrollable webpages.
+ The reason is that 100% is relative to the content size here, and we want 100%
+ relative to the viewport size. However, since there is no such a thing in CSS,
+ we set an absolute file.
+
+ A known problem with this will be rotating the device when in fullscreen mode
+ that we can address when rotating is supported.
+
+ Internally reviewed by Jacky Jiang.
+
+ * WebCoreSupport/ChromeClientBlackBerry.cpp:
+ (WebCore::ChromeClientBlackBerry::fullScreenRendererChanged):
+
2012-06-05 Antonio Gomes <[email protected]>
[BlackBerry] Implement a top-down in-region boundary detection in InRegionScrollableArea
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp (119680 => 119681)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-07 04:34:40 UTC (rev 119680)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp 2012-06-07 04:34:56 UTC (rev 119681)
@@ -742,8 +742,12 @@
{
// Once we go fullscreen using the new FULLSCREEN_API code path, we have to take into account
// our port specific page scaling.
- if (fullScreenRenderer)
- fullScreenRenderer->style()->setWidth(Length(100.0 / m_webPagePrivate->currentScale(), Percent));
+ if (fullScreenRenderer) {
+ // FIXME: Since we are setting an absolute width value here, it won't work for cases
+ // where we change the viewport size as we go. For example, rotate the device while
+ // in fullscreen mode.
+ fullScreenRenderer->style()->setWidth(Length(m_webPagePrivate->viewportSize().width(), Fixed));
+ }
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
