Title: [119748] trunk/Tools
- Revision
- 119748
- Author
- [email protected]
- Date
- 2012-06-07 13:06:57 -0700 (Thu, 07 Jun 2012)
Log Message
[chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
https://bugs.webkit.org/show_bug.cgi?id=77368
Reviewed by Ojan Vafai.
It doesn't look like we ever get a rect with width or height of 0.
I ran css1, css2.1, fast/forms, and tables without any crashes.
* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (119747 => 119748)
--- trunk/Tools/ChangeLog 2012-06-07 19:44:59 UTC (rev 119747)
+++ trunk/Tools/ChangeLog 2012-06-07 20:06:57 UTC (rev 119748)
@@ -1,3 +1,16 @@
+2012-06-07 Tony Chang <[email protected]>
+
+ [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
+ https://bugs.webkit.org/show_bug.cgi?id=77368
+
+ Reviewed by Ojan Vafai.
+
+ It doesn't look like we ever get a rect with width or height of 0.
+ I ran css1, css2.1, fast/forms, and tables without any crashes.
+
+ * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
+ (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
+
2012-06-07 Dirk Pranke <[email protected]>
run-webkit-tests --lint-test-files gives an error when run on linux
Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp (119747 => 119748)
--- trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp 2012-06-07 19:44:59 UTC (rev 119747)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp 2012-06-07 20:06:57 UTC (rev 119748)
@@ -51,7 +51,7 @@
static SkIRect webRectToSkIRect(const WebRect& webRect)
{
SkIRect irect;
- irect.set(webRect.x, webRect.y, webRect.x + webRect.width, webRect.y + webRect.height);
+ irect.set(webRect.x, webRect.y, webRect.x + webRect.width - 1, webRect.y + webRect.height - 1);
return irect;
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
