Title: [119811] trunk/Source/WebCore
- Revision
- 119811
- Author
- [email protected]
- Date
- 2012-06-08 01:14:41 -0700 (Fri, 08 Jun 2012)
Log Message
HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
https://bugs.webkit.org/show_bug.cgi?id=88603
Reviewed by Pavel Feldman.
A 204 response doesn't have an entity body, so its MIME type is kind of
meaningless. We shouldn't spam the console with a warning about MIME
types.
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119810 => 119811)
--- trunk/Source/WebCore/ChangeLog 2012-06-08 08:01:27 UTC (rev 119810)
+++ trunk/Source/WebCore/ChangeLog 2012-06-08 08:14:41 UTC (rev 119811)
@@ -1,3 +1,17 @@
+2012-06-08 Adam Barth <[email protected]>
+
+ HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
+ https://bugs.webkit.org/show_bug.cgi?id=88603
+
+ Reviewed by Pavel Feldman.
+
+ A 204 response doesn't have an entity body, so its MIME type is kind of
+ meaningless. We shouldn't spam the console with a warning about MIME
+ types.
+
+ * inspector/front-end/NetworkManager.js:
+ (WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
+
2012-06-08 Yoshifumi Inoue <[email protected]>
[Forms] Drop StepRange::NumberWithDecimalPlacesOrMissing
Modified: trunk/Source/WebCore/inspector/front-end/NetworkManager.js (119810 => 119811)
--- trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2012-06-08 08:01:27 UTC (rev 119810)
+++ trunk/Source/WebCore/inspector/front-end/NetworkManager.js 2012-06-08 08:14:41 UTC (rev 119811)
@@ -233,7 +233,7 @@
// Also, if a URL like http://localhost/wiki/load.php?debug=true&lang=en produces text/css and gets reloaded,
// it is 304 Not Modified and its guessed mime-type is text/php, which is wrong.
// Don't check for mime-types in 304-resources.
- if (networkRequest.hasErrorStatusCode() || networkRequest.statusCode === 304)
+ if (networkRequest.hasErrorStatusCode() || networkRequest.statusCode === 304 || networkRequest.statusCode === 204)
return true;
if (typeof networkRequest.type === "undefined"
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
