Title: [119832] trunk
- Revision
- 119832
- Author
- sch...@chromium.org
- Date
- 2012-06-08 08:13:32 -0700 (Fri, 08 Jun 2012)
Log Message
Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
https://bugs.webkit.org/show_bug.cgi?id=88604
Reviewed by Kent Tamura.
Tools:
DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::requestPointerUnlock):
LayoutTests:
Removed CRASH expectation.
Test is no longer crashing with this fix to DumpRenderTree.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (119831 => 119832)
--- trunk/LayoutTests/ChangeLog 2012-06-08 15:01:00 UTC (rev 119831)
+++ trunk/LayoutTests/ChangeLog 2012-06-08 15:13:32 UTC (rev 119832)
@@ -1,3 +1,15 @@
+2012-06-07 Vincent Scheib <sch...@chromium.org>
+
+ Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=88604
+
+ Reviewed by Kent Tamura.
+
+ Removed CRASH expectation.
+ Test is no longer crashing with this fix to DumpRenderTree.
+
+ * platform/chromium/TestExpectations:
+
2012-06-08 Stephen Chenney <schen...@chromium.org>
WebCore::ImageBuffer.cpp has broken color table code
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (119831 => 119832)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-08 15:01:00 UTC (rev 119831)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-06-08 15:13:32 UTC (rev 119832)
@@ -3976,8 +3976,6 @@
BUGWK88593 : fast/table/multiple-captions-display.xhtml = PASS IMAGE IMAGE+TEXT
-BUGWK88604 DEBUG : pointer-lock/pointerlockchange-pointerlockerror-events.html = CRASH
-
// Needs rebaseline after the bots cycle.
BUG_OJAN WIN MAC : tables/mozilla/bugs/bug131020.html = PASS FAIL
BUGLEVIW LEOPARD LION WIN LINUX : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS FAIL MISSING
Modified: trunk/Tools/ChangeLog (119831 => 119832)
--- trunk/Tools/ChangeLog 2012-06-08 15:01:00 UTC (rev 119831)
+++ trunk/Tools/ChangeLog 2012-06-08 15:13:32 UTC (rev 119832)
@@ -1,3 +1,16 @@
+2012-06-07 Vincent Scheib <sch...@chromium.org>
+
+ Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=88604
+
+ Reviewed by Kent Tamura.
+
+ DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
+ Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
+
+ * DumpRenderTree/chromium/WebViewHost.cpp:
+ (WebViewHost::requestPointerUnlock):
+
2012-06-08 Hans Wennborg <h...@chromium.org>
Speech _javascript_ API: mock WebSpeechRecognizer for DumpRenderTree
Modified: trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp (119831 => 119832)
--- trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2012-06-08 15:01:00 UTC (rev 119831)
+++ trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp 2012-06-08 15:13:32 UTC (rev 119832)
@@ -845,7 +845,8 @@
void WebViewHost::requestPointerUnlock()
{
- postDelayedTask(new HostMethodTask(this, &WebViewHost::didLosePointerLock), 0);
+ if (m_pointerLocked)
+ postDelayedTask(new HostMethodTask(this, &WebViewHost::didLosePointerLock), 0);
}
bool WebViewHost::isPointerLocked()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
