Diff
Modified: trunk/Source/WebCore/ChangeLog (119867 => 119868)
--- trunk/Source/WebCore/ChangeLog 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/ChangeLog 2012-06-08 21:59:30 UTC (rev 119868)
@@ -1,3 +1,27 @@
+2012-06-08 David Grogan <[email protected]>
+
+ IndexedDB: rename some instances of open to registerFrontendCallbacks
+ https://bugs.webkit.org/show_bug.cgi?id=88611
+
+ We should still make the change in the WebKit API.
+
+ Reviewed by Tony Chang.
+
+ No new tests, just a method rename.
+
+ * Modules/indexeddb/IDBDatabase.cpp:
+ (WebCore::IDBDatabase::registerFrontendCallbacks):
+ * Modules/indexeddb/IDBDatabase.h:
+ (IDBDatabase):
+ * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+ (WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
+ * Modules/indexeddb/IDBDatabaseBackendImpl.h:
+ (IDBDatabaseBackendImpl):
+ * Modules/indexeddb/IDBDatabaseBackendInterface.h:
+ (IDBDatabaseBackendInterface):
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::onSuccess):
+
2012-06-08 Dana Jansens <[email protected]>
[chromium] Skip willDraw() and didDraw() on fully occluded layers
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2012-06-08 21:59:30 UTC (rev 119868)
@@ -237,9 +237,9 @@
enqueueEvent(IDBVersionChangeEvent::create(version, eventNames().versionchangeEvent));
}
-void IDBDatabase::open()
+void IDBDatabase::registerFrontendCallbacks()
{
- m_backend->open(m_databaseCallbacks);
+ m_backend->registerFrontendCallbacks(m_databaseCallbacks);
}
void IDBDatabase::enqueueEvent(PassRefPtr<Event> event)
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.h 2012-06-08 21:59:30 UTC (rev 119868)
@@ -86,7 +86,7 @@
virtual const AtomicString& interfaceName() const;
virtual ScriptExecutionContext* scriptExecutionContext() const;
- void open();
+ void registerFrontendCallbacks();
void enqueueEvent(PassRefPtr<Event>);
bool dispatchEvent(PassRefPtr<Event> event, ExceptionCode& ec) { return EventTarget::dispatchEvent(event, ec); }
virtual bool dispatchEvent(PassRefPtr<Event>);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp 2012-06-08 21:59:30 UTC (rev 119868)
@@ -321,7 +321,7 @@
return IDBTransactionBackendImpl::create(objectStoreNames, mode, this);
}
-void IDBDatabaseBackendImpl::open(PassRefPtr<IDBDatabaseCallbacks> callbacks)
+void IDBDatabaseBackendImpl::registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks> callbacks)
{
m_databaseCallbacksSet.add(RefPtr<IDBDatabaseCallbacks>(callbacks));
}
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h 2012-06-08 21:59:30 UTC (rev 119868)
@@ -53,8 +53,7 @@
static const int64_t InvalidId = 0;
int64_t id() const { return m_id; }
- // FIXME: Rename "open" to something more descriptive, like registerFrontEndCallbacks.
- void open(PassRefPtr<IDBDatabaseCallbacks>);
+ void registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks>);
void openConnection(PassRefPtr<IDBCallbacks>);
void deleteDatabase(PassRefPtr<IDBCallbacks>);
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h 2012-06-08 21:59:30 UTC (rev 119868)
@@ -62,7 +62,7 @@
virtual PassRefPtr<IDBTransactionBackendInterface> transaction(DOMStringList* storeNames, unsigned short mode, ExceptionCode&) = 0;
virtual void close(PassRefPtr<IDBDatabaseCallbacks>) = 0;
- virtual void open(PassRefPtr<IDBDatabaseCallbacks>) = 0;
+ virtual void registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks>) = 0;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (119867 => 119868)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2012-06-08 21:59:30 UTC (rev 119868)
@@ -254,7 +254,7 @@
return;
RefPtr<IDBDatabase> idbDatabase = IDBDatabase::create(scriptExecutionContext(), backend);
- idbDatabase->open();
+ idbDatabase->registerFrontendCallbacks();
m_result = IDBAny::create(idbDatabase.release());
enqueueEvent(createSuccessEvent());
Modified: trunk/Source/WebKit/chromium/ChangeLog (119867 => 119868)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-06-08 21:59:30 UTC (rev 119868)
@@ -1,3 +1,19 @@
+2012-06-08 David Grogan <[email protected]>
+
+ IndexedDB: rename some instances of open to registerFrontendCallbacks
+ https://bugs.webkit.org/show_bug.cgi?id=88611
+
+ Reviewed by Tony Chang.
+
+ * src/IDBDatabaseBackendProxy.cpp:
+ (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
+ * src/IDBDatabaseBackendProxy.h:
+ (IDBDatabaseBackendProxy):
+ * src/WebIDBDatabaseImpl.cpp:
+ (WebKit::WebIDBDatabaseImpl::open):
+ * src/WebIDBDatabaseImpl.h:
+ (WebIDBDatabaseImpl):
+
2012-06-08 Dana Jansens <[email protected]>
[chromium] Skip willDraw() and didDraw() on fully occluded layers
Modified: trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp (119867 => 119868)
--- trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp 2012-06-08 21:59:30 UTC (rev 119868)
@@ -115,7 +115,7 @@
m_webIDBDatabase->close();
}
-void IDBDatabaseBackendProxy::open(PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks)
+void IDBDatabaseBackendProxy::registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks)
{
m_webIDBDatabase->open(new WebIDBDatabaseCallbacksImpl(databaseCallbacks));
}
Modified: trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h (119867 => 119868)
--- trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h 2012-06-08 21:59:30 UTC (rev 119868)
@@ -52,7 +52,7 @@
virtual PassRefPtr<WebCore::IDBTransactionBackendInterface> transaction(WebCore::DOMStringList* storeNames, unsigned short mode, WebCore::ExceptionCode&);
virtual void close(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
- virtual void open(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
+ virtual void registerFrontendCallbacks(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
private:
IDBDatabaseBackendProxy(PassOwnPtr<WebIDBDatabase>);
Modified: trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp (119867 => 119868)
--- trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp 2012-06-08 21:59:30 UTC (rev 119868)
@@ -111,7 +111,7 @@
{
ASSERT(!m_databaseCallbacks);
m_databaseCallbacks = IDBDatabaseCallbacksProxy::create(adoptPtr(callbacks));
- m_databaseBackend->open(m_databaseCallbacks);
+ m_databaseBackend->registerFrontendCallbacks(m_databaseCallbacks);
}
} // namespace WebKit
Modified: trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h (119867 => 119868)
--- trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h 2012-06-08 21:37:33 UTC (rev 119867)
+++ trunk/Source/WebKit/chromium/src/WebIDBDatabaseImpl.h 2012-06-08 21:59:30 UTC (rev 119868)
@@ -59,6 +59,7 @@
virtual WebIDBTransaction* transaction(const WebDOMStringList& names, unsigned short mode, WebExceptionCode&);
virtual void close();
+ // FIXME: Rename "open" to registerFrontendCallbacks.
virtual void open(WebIDBDatabaseCallbacks*);
private:
