Diff
Modified: trunk/LayoutTests/ChangeLog (119870 => 119871)
--- trunk/LayoutTests/ChangeLog 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/ChangeLog 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,3 +1,18 @@
+2012-06-08 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r119514.
+ http://trac.webkit.org/changeset/119514
+ https://bugs.webkit.org/show_bug.cgi?id=88664
+
+ Broke JSFiddle.net (Requested by arv on #webkit).
+
+ * fast/dom/Window/window-property-shadowing-name-expected.txt:
+ * fast/dom/Window/window-property-shadowing-name.html:
+ * fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
+ * fast/dom/Window/window-property-shadowing-onclick.html: Removed.
+ * platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt: Removed.
+ * platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt: Removed.
+
2012-06-08 Ojan Vafai <[email protected]>
Second wave of Chromium rebaselines after skia change. See crbug.com/131829.
Modified: trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt (119870 => 119871)
--- trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name-expected.txt 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,3 +1,3 @@
This page tests whether declaring a variable named "name" changes the window's name in the DOM. If the test passes, you'll see a PASS message below.
-FAIL
+PASS
Modified: trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name.html (119870 => 119871)
--- trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name.html 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/fast/dom/Window/window-property-shadowing-name.html 2012-06-08 23:00:37 UTC (rev 119871)
@@ -7,9 +7,6 @@
<script>
-// ECMAScript 5.2 fixes this behavior to better match Internet Explorer and Firefox.
-// https://bugs.ecmascript.org/show_bug.cgi?id=78
-
function log(result)
{
document.querySelector("pre").textContent = result;
@@ -22,8 +19,8 @@
var name = "test";
var w = window.open("_javascript_:void 0", "test");
if (w === window)
- log("FAIL");
-else
log("PASS");
+else
+ log("FAIL");
</script>
Deleted: trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick-expected.txt (119870 => 119871)
--- trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick-expected.txt 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick-expected.txt 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,7 +0,0 @@
-This tests the ES5.2 behavior where global variables should not trigger setters on the Window object
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-FAIL onClickCalled should be false. Was true.
-
Deleted: trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick.html (119870 => 119871)
--- trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick.html 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/fast/dom/Window/window-property-shadowing-onclick.html 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<script src=""
-<script>
-
-description('This tests the ES5.2 behavior where global variables should not trigger setters on the Window object');
-
-if (window.layoutTestController)
- layoutTestController.dumpAsText();
-
-var _onClickCalled_ = false;
-
-var _onclick_ = function(e) {
- _onClickCalled_ = true;
-};
-
-var e = document.createEvent('MouseEvents');
-e.initMouseEvent('click', true, true, window,
- 0, 0, 0, 0, 0, false, false, false, false, 0, null);
-document.dispatchEvent(e);
-
-shouldBeFalse('onClickCalled');
-
-</script>
-<script src=""
Deleted: trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt (119870 => 119871)
--- trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-name-expected.txt 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,3 +0,0 @@
-This page tests whether declaring a variable named "name" changes the window's name in the DOM. If the test passes, you'll see a PASS message below.
-
-PASS
Deleted: trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt (119870 => 119871)
--- trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/LayoutTests/platform/chromium/fast/dom/Window/window-property-shadowing-onclick-expected.txt 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,7 +0,0 @@
-This tests the ES5.2 behavior where global variables should not trigger setters on the Window object
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS onClickCalled is false
-
Modified: trunk/Source/WebCore/ChangeLog (119870 => 119871)
--- trunk/Source/WebCore/ChangeLog 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/Source/WebCore/ChangeLog 2012-06-08 23:00:37 UTC (rev 119871)
@@ -1,3 +1,16 @@
+2012-06-08 Sheriff Bot <[email protected]>
+
+ Unreviewed, rolling out r119514.
+ http://trac.webkit.org/changeset/119514
+ https://bugs.webkit.org/show_bug.cgi?id=88664
+
+ Broke JSFiddle.net (Requested by arv on #webkit).
+
+ * bindings/v8/V8DOMWindowShell.cpp:
+ (WebCore::V8DOMWindowShell::initContextIfNeeded):
+ * bindings/v8/WorkerContextExecutionProxy.cpp:
+ (WebCore::WorkerContextExecutionProxy::initIsolate):
+
2012-06-08 Ryosuke Niwa <[email protected]>
Crash in WebCore::InsertParagraphSeparatorCommand::doApply
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp (119870 => 119871)
--- trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp 2012-06-08 23:00:37 UTC (rev 119871)
@@ -300,10 +300,6 @@
#endif
V8BindingPerIsolateData::ensureInitialized(v8::Isolate::GetCurrent());
- // FIXME: Remove the following 2 lines when V8 default has changed.
- const char es52GlobalsFlag[] = "--es52_globals";
- v8::V8::SetFlagsFromString(es52GlobalsFlag, sizeof(es52GlobalsFlag));
-
isV8Initialized = true;
}
Modified: trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp (119870 => 119871)
--- trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp 2012-06-08 22:35:35 UTC (rev 119870)
+++ trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp 2012-06-08 23:00:37 UTC (rev 119871)
@@ -122,10 +122,6 @@
v8::V8::SetGlobalGCPrologueCallback(&V8GCController::gcPrologue);
v8::V8::SetGlobalGCEpilogueCallback(&V8GCController::gcEpilogue);
- // FIXME: Remove the following 2 lines when V8 default has changed.
- const char es52GlobalsFlag[] = "--es52_globals";
- v8::V8::SetFlagsFromString(es52GlobalsFlag, sizeof(es52GlobalsFlag));
-
v8::ResourceConstraints resource_constraints;
uint32_t here;
resource_constraints.set_stack_limit(&here - kWorkerMaxStackSize / sizeof(uint32_t*));
