Title: [119906] trunk/Source/WebCore
Revision
119906
Author
[email protected]
Date
2012-06-09 09:53:17 -0700 (Sat, 09 Jun 2012)

Log Message

Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
https://bugs.webkit.org/show_bug.cgi?id=88710

Reviewed by Pavel Feldman.

* inspector/front-end/inspector.js:
(WebInspector.documentClick.followLink):
(WebInspector.documentClick):
(WebInspector._showAnchorLocation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (119905 => 119906)


--- trunk/Source/WebCore/ChangeLog	2012-06-09 16:48:07 UTC (rev 119905)
+++ trunk/Source/WebCore/ChangeLog	2012-06-09 16:53:17 UTC (rev 119906)
@@ -1,5 +1,17 @@
 2012-06-09  Vsevolod Vlasov  <[email protected]>
 
+        Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
+        https://bugs.webkit.org/show_bug.cgi?id=88710
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/inspector.js:
+        (WebInspector.documentClick.followLink):
+        (WebInspector.documentClick):
+        (WebInspector._showAnchorLocation):
+
+2012-06-09  Vsevolod Vlasov  <[email protected]>
+
         Web Inspector: Only expand root domain in Sources/Scripts panel
         https://bugs.webkit.org/show_bug.cgi?id=88135
 

Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (119905 => 119906)


--- trunk/Source/WebCore/inspector/front-end/inspector.js	2012-06-09 16:48:07 UTC (rev 119905)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js	2012-06-09 16:53:17 UTC (rev 119906)
@@ -636,7 +636,7 @@
             return;
         }
 
-        WebInspector.showPanel("resources");
+        InspectorFrontendHost.openInNewTab(anchor.href);
     }
 
     if (WebInspector.followLinkTimeout)
@@ -967,11 +967,19 @@
 {
     if (WebInspector.openAnchorLocationRegistry.dispatch({ url: anchor.href, lineNumber: anchor.lineNumber}))
         return true;
-    var preferedPanel = this.panels[anchor.preferredPanel || "resources"];
-    if (WebInspector._showAnchorLocationInPanel(anchor, preferedPanel))
-        return true;
-    if (preferedPanel !== this.panels.resources && WebInspector._showAnchorLocationInPanel(anchor, this.panels.resources))
-        return true;
+    var preferredPanels = [];
+    if (this.panels[anchor.preferredPanel])
+        preferredPanels.push(this.panels[anchor.preferredPanel]);
+    if (this.panels.scripts)
+        preferredPanels.push(this.panels.scripts);
+    if (this.panels.resources)
+        preferredPanels.push(this.panels.resources);
+    if (this.panels.network)
+        preferredPanels.push(this.panels.network);
+    for (var i = 0; i < preferredPanels.length; ++i) {
+        if (WebInspector._showAnchorLocationInPanel(anchor, preferredPanels[i]))
+            return true;
+    }
     return false;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to