Title: [119908] trunk/Source/WebCore
- Revision
- 119908
- Author
- [email protected]
- Date
- 2012-06-09 10:11:58 -0700 (Sat, 09 Jun 2012)
Log Message
[Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
https://bugs.webkit.org/show_bug.cgi?id=88703
The bug originated from StillImage that is not override
Image::currentFrameHasAlpha(), so it always returns false.
StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
TextureMapperBackingStore thinks contents does not have alpha.
Covered by existing compositing tests.
Patch by Huang Dongsung <[email protected]> on 2012-06-09
Reviewed by Noam Rosenthal.
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::currentFrameHasAlpha):
(WebCore):
* platform/graphics/qt/StillImageQt.h:
(StillImage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (119907 => 119908)
--- trunk/Source/WebCore/ChangeLog 2012-06-09 17:01:44 UTC (rev 119907)
+++ trunk/Source/WebCore/ChangeLog 2012-06-09 17:11:58 UTC (rev 119908)
@@ -1,3 +1,23 @@
+2012-06-09 Huang Dongsung <[email protected]>
+
+ [Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
+ https://bugs.webkit.org/show_bug.cgi?id=88703
+
+ The bug originated from StillImage that is not override
+ Image::currentFrameHasAlpha(), so it always returns false.
+ StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
+ TextureMapperBackingStore thinks contents does not have alpha.
+
+ Covered by existing compositing tests.
+
+ Reviewed by Noam Rosenthal.
+
+ * platform/graphics/qt/StillImageQt.cpp:
+ (WebCore::StillImage::currentFrameHasAlpha):
+ (WebCore):
+ * platform/graphics/qt/StillImageQt.h:
+ (StillImage):
+
2012-06-09 Victor Carbune <[email protected]>
Basic support for timestamps within a TextTrackCue
Modified: trunk/Source/WebCore/platform/graphics/qt/StillImageQt.cpp (119907 => 119908)
--- trunk/Source/WebCore/platform/graphics/qt/StillImageQt.cpp 2012-06-09 17:01:44 UTC (rev 119907)
+++ trunk/Source/WebCore/platform/graphics/qt/StillImageQt.cpp 2012-06-09 17:11:58 UTC (rev 119908)
@@ -52,6 +52,11 @@
delete m_pixmap;
}
+bool StillImage::currentFrameHasAlpha()
+{
+ return m_pixmap->hasAlpha();
+}
+
IntSize StillImage::size() const
{
return IntSize(m_pixmap->width(), m_pixmap->height());
Modified: trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h (119907 => 119908)
--- trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-06-09 17:01:44 UTC (rev 119907)
+++ trunk/Source/WebCore/platform/graphics/qt/StillImageQt.h 2012-06-09 17:11:58 UTC (rev 119908)
@@ -44,6 +44,8 @@
return adoptRef(new StillImage(pixmap));
}
+ virtual bool currentFrameHasAlpha();
+
// FIXME: StillImages are underreporting decoded sizes and will be unable
// to prune because these functions are not implemented yet.
virtual void destroyDecodedData(bool destroyAll = true) { Q_UNUSED(destroyAll); }
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
