Title: [119944] trunk/LayoutTests
- Revision
- 119944
- Author
- [email protected]
- Date
- 2012-06-10 12:48:56 -0700 (Sun, 10 Jun 2012)
Log Message
Removing mixed content tests' dependency on WebKitBlobBuilder:
https://bugs.webkit.org/show_bug.cgi?id=88736
http/tests/security/mixedContent/blob-url-in-iframe.html and
http/tests/security/mixedContent/filesystem-url-in-iframe.html both
relied on WebKitBlobBuilder, which is disabled on some builds. `new
Blob()` is the new hotness that these tests should be using instead. This
patch migrates both tests to the new API.
It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
remains disabled, as the filesystem APIs are disabled entirely).
Patch by Mike West <[email protected]> on 2012-06-10
Reviewed by Adam Barth.
* http/tests/security/mixedContent/blob-url-in-iframe.html:
* http/tests/security/mixedContent/filesystem-url-in-iframe.html:
* platform/mac/Skipped:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (119943 => 119944)
--- trunk/LayoutTests/ChangeLog 2012-06-10 19:19:19 UTC (rev 119943)
+++ trunk/LayoutTests/ChangeLog 2012-06-10 19:48:56 UTC (rev 119944)
@@ -1,3 +1,23 @@
+2012-06-10 Mike West <[email protected]>
+
+ Removing mixed content tests' dependency on WebKitBlobBuilder:
+ https://bugs.webkit.org/show_bug.cgi?id=88736
+
+ http/tests/security/mixedContent/blob-url-in-iframe.html and
+ http/tests/security/mixedContent/filesystem-url-in-iframe.html both
+ relied on WebKitBlobBuilder, which is disabled on some builds. `new
+ Blob()` is the new hotness that these tests should be using instead. This
+ patch migrates both tests to the new API.
+
+ It also reenables blob-url-in-iframe.html on mac (filesystem-url-in-iframe.html
+ remains disabled, as the filesystem APIs are disabled entirely).
+
+ Reviewed by Adam Barth.
+
+ * http/tests/security/mixedContent/blob-url-in-iframe.html:
+ * http/tests/security/mixedContent/filesystem-url-in-iframe.html:
+ * platform/mac/Skipped:
+
2012-06-10 Christophe Dumez <[email protected]>
[EFL][GTK] media/track/track-cue-rendering-inner-timestamps.html is failing
Modified: trunk/LayoutTests/http/tests/security/mixedContent/blob-url-in-iframe.html (119943 => 119944)
--- trunk/LayoutTests/http/tests/security/mixedContent/blob-url-in-iframe.html 2012-06-10 19:19:19 UTC (rev 119943)
+++ trunk/LayoutTests/http/tests/security/mixedContent/blob-url-in-iframe.html 2012-06-10 19:48:56 UTC (rev 119944)
@@ -18,14 +18,13 @@
layoutTestController.waitUntilDone();
}
var iframe = document.querySelector('iframe');
-var bb = new WebKitBlobBuilder();
-bb.append('<h1>PASS (1/1)</h1>');
-bb.getBlob('text/html');
iframe._onload_ = function () {
if (window.layoutTestController)
layoutTestController.notifyDone();
};
-iframe.src = ""
+
+var b = new Blob(['<h1>PASS (1/1)</h1>'], { type: 'text/html' });
+iframe.src = ""
</script>
</body>
</html>
Modified: trunk/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html (119943 => 119944)
--- trunk/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html 2012-06-10 19:19:19 UTC (rev 119943)
+++ trunk/LayoutTests/http/tests/security/mixedContent/filesystem-url-in-iframe.html 2012-06-10 19:48:56 UTC (rev 119944)
@@ -34,9 +34,8 @@
};
// Create a new Blob and write it to log.txt.
- var bb = new WebKitBlobBuilder();
- bb.append('PASS (2/2): File displayed');
- fileWriter.write(bb.getBlob('text/html'));
+ var b = new Blob(['PASS (2/2): File displayed'], { type: 'text/html' });
+ fileWriter.write(b);
});
});
});
Modified: trunk/LayoutTests/platform/mac/Skipped (119943 => 119944)
--- trunk/LayoutTests/platform/mac/Skipped 2012-06-10 19:19:19 UTC (rev 119943)
+++ trunk/LayoutTests/platform/mac/Skipped 2012-06-10 19:48:56 UTC (rev 119944)
@@ -791,8 +791,6 @@
# The Mac port does not support the legacy WebKitBlobBuilder class.
fast/files/blob-builder-crash.html
-# https://bugs.webkit.org/show_bug.cgi?id=88736
-http/tests/security/mixedContent/blob-url-in-iframe.html
# [Mac] inspector/debugger/linkifier.html is flakey
# https://bugs.webkit.org/show_bug.cgi?id=85319
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
